linux-kernel - Re: [PATCH] virtio-mmio: Remove virtqueue list from mmio device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250529073145.ss5ejipnlbl6v5fj@vireshk-i7>
Date: Thu, 29 May 2025 13:01:45 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Jason Wang <jasowang@...hat.com>
Cc: "Michael S. Tsirkin" <mst@...hat.com>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	Eugenio Pérez <eperezma@...hat.com>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Alex Bennée <alex.bennee@...aro.org>,
	Bill Mills <bill.mills@...aro.org>, virtualization@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virtio-mmio: Remove virtqueue list from mmio device

On 29-05-25, 14:05, Jason Wang wrote:
> On Wed, May 21, 2025 at 7:34 PM Viresh Kumar <viresh.kumar@...aro.org> wrote:
> >
> > The MMIO transport implementation creates a list of virtqueues for a
> > virtio device, while the same is already available in the struct
> > virtio_device.
> >
> > Don't create a duplicate list, and use the other one instead.
> >
> > While at it, fix the virtio_device_for_each_vq() macro to accept an
> > argument like "&vm_dev->vdev" (which currently fails to build).
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> > ---
> 
> Acked-by: Jason Wang <jasowang@...hat.com>
> 
> Btw, virtio-vdpa may need the same optimization.

Sent a patch for that now.

https://lore.kernel.org/all/7808f2f7e484987b95f172fffb6c71a5da20ed1e.1748503784.git.viresh.kumar@linaro.org/

-- 
viresh