| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CABGWkvrY+27C=Ds8uCWBp4seQiV1RNs2dp1jNRPpUNxgNOSxYg@mail.gmail.com>
Date: Thu, 29 May 2025 10:13:20 +0200
From: Dario Binacchi <dario.binacchi@...rulasolutions.com>
To: Frank Li <Frank.li@....com>
Cc: linux-kernel@...r.kernel.org, michael@...rulasolutions.com,
linux-amarula@...rulasolutions.com, Conor Dooley <conor+dt@...nel.org>,
Fabio Estevam <festevam@...il.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Pengutronix Kernel Team <kernel@...gutronix.de>, Rob Herring <robh@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>, devicetree@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 4/4] ARM: dts: mxs: support i.MX28 Amarula rmm board
Hi Frank,
On Wed, May 28, 2025 at 5:06 PM Frank Li <Frank.li@....com> wrote:
>
> On Wed, May 28, 2025 at 02:11:41PM +0200, Dario Binacchi wrote:
> > The board includes the following resources:
> > - 256 Mbytes NAND Flash
> > - 128 Mbytes DRAM DDR2
> > - CAN
> > - USB 2.0 high-speed/full-speed
> > - Ethernet MAC
> >
> > Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>
> >
> > ---
> >
> > Changes in v2:
> > - In imx28-amarula-rmm.dts:
> > - Replace '-' with '@' for the pinctrl sub-nodes.
> > - Replace edt,edt-ft5x06 with edt,edt-ft5306.
> > - Drop LCD reset hog pin.
> > - Add correct #address-cells and #size-cells to gpmi node.
> > - Replace edt-ft5x06@38 with touchscreen@38.
> > - Drop from commit messages all references to LCD display.
> > - Add patch [1/4] "dt-bindings: mfd: convert mxs-lradc bindings to
> > json-schema".
> >
> > arch/arm/boot/dts/nxp/mxs/Makefile | 1 +
> > .../boot/dts/nxp/mxs/imx28-amarula-rmm.dts | 303 ++++++++++++++++++
>
> please run https://github.com/lznuaa/dt-format to keep nice node/property
> order for new dts file.
Thank you for the suggestion. I made some changes, although I didn’t follow the
dt-format output for imx28-amarula-rmm.dtsi to the letter. In some cases, when
I had to choose between alphabetical order and the “customary” conventions of
DTS files, I opted for the latter.
Thanks and regards,
Dario
>
> Frank
>
> > 2 files changed, 304 insertions(+)
> > create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-amarula-rmm.dts
> >
> > diff --git a/arch/arm/boot/dts/nxp/mxs/Makefile b/arch/arm/boot/dts/nxp/mxs/Makefile
> > index 96dd31ea19ba..d72ba702b6fa 100644
> > --- a/arch/arm/boot/dts/nxp/mxs/Makefile
> > +++ b/arch/arm/boot/dts/nxp/mxs/Makefile
> > @@ -5,6 +5,7 @@ dtb-$(CONFIG_ARCH_MXS) += \
> > imx23-sansa.dtb \
> > imx23-stmp378x_devb.dtb \
> > imx23-xfi3.dtb \
> > + imx28-amarula-rmm.dtb \
> > imx28-apf28.dtb \
> > imx28-apf28dev.dtb \
> > imx28-apx4devkit.dtb \
> > diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-amarula-rmm.dts b/arch/arm/boot/dts/nxp/mxs/imx28-amarula-rmm.dts
> > new file mode 100644
> > index 000000000000..5daa9e22715d
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/nxp/mxs/imx28-amarula-rmm.dts
> > @@ -0,0 +1,303 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (C) 2025 Amarula Solutions, Dario Binacchi <dario.binacchi@...rulasolutions.com>
> > + */
> > +
> > +/dts-v1/;
> > +#include "imx28.dtsi"
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +/ {
> > + model = "Amarula i.MX28 rmm";
> > + compatible = "amarula,imx28-rmm", "fsl,imx28";
> > +
> > + memory@...00000 {
> > + device_type = "memory";
> > + reg = <0x40000000 0x08000000>;
> > + };
> > +
> > + reg_5v: regulator-5v {
> > + compatible = "regulator-fixed";
> > + regulator-name = "5v";
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + regulator-always-on;
> > + };
> > +
> > + reg_3v3: regulator-3v3 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "3v3";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-always-on;
> > + };
> > +
> > + reg_1v8: regulator-1v8 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "1v8";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + };
> > +
> > + reg_fec_3v3: regulator-fec-3v3 {
> > + compatible = "regulator-fixed";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&fec_3v3_enable_pin>;
> > + regulator-name = "fec-3v3";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + gpios = <&gpio3 27 GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > + startup-delay-us = <300000>;
> > + vin-supply = <®_5v>;
> > + };
> > +
> > + reg_usb0_vbus: regulator-usb0-vbus {
> > + compatible = "regulator-fixed";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&usb0_vbus_enable_pin>;
> > + regulator-name = "usb0_vbus";
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + gpio = <&gpio2 5 GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > + regulator-always-on;
> > + };
> > +
> > + reg_usb1_vbus: regulator-usb1-vbus {
> > + compatible = "regulator-fixed";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&usb1_vbus_enable_pin>;
> > + regulator-name = "usb1_vbus";
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + gpio = <&gpio2 6 GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > + regulator-always-on;
> > + };
> > +
> > + backlight {
> > + compatible = "pwm-backlight";
> > + pwms = <&pwm 4 5000000 0>;
> > + brightness-levels = <0 255>;
> > + num-interpolated-steps = <255>;
> > + default-brightness-level = <255>;
> > + power-supply = <®_5v>;
> > + };
> > +
> > + beeper {
> > + compatible = "pwm-beeper";
> > + pwms = <&pwm 7 100000 0>;
> > + };
> > +
> > + leds {
> > + compatible = "gpio-leds";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&leds_pins>;
> > +
> > + led-0 {
> > + label = "status";
> > + gpios = <&gpio2 7 GPIO_ACTIVE_HIGH>;
> > + default-state = "off";
> > + };
> > +
> > + led-1 {
> > + label = "x22_5";
> > + gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
> > + default-state = "off";
> > + };
> > +
> > + led-2 {
> > + label = "x22_4";
> > + gpios = <&gpio3 17 GPIO_ACTIVE_HIGH>;
> > + default-state = "off";
> > + };
> > + };
> > +};
> > +
> > +&auart0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&auart0_2pins_a>;
> > + status = "okay";
> > +};
> > +
> > +&auart1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&auart1_pins_a>;
> > + status = "okay";
> > +};
> > +
> > +&can0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&can0_pins_a>;
> > + xceiver-supply = <®_3v3>;
> > + status = "okay";
> > +};
> > +
> > +&duart {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&duart_pins_b>;
> > + status = "okay";
> > +};
> > +
> > +&duart_pins_b {
> > + fsl,voltage = <MXS_VOLTAGE_LOW>;
> > +};
> > +
> > +&gpmi {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&gpmi_pins_a &gpmi_status_cfg>;
> > + status = "okay";
> > +};
> > +
> > +&i2c0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&i2c0_pins_a>;
> > + status = "okay";
> > +
> > + touchscreen: touchscreen@38 {
> > + compatible = "edt,edt-ft5306";
> > + reg = <0x38>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&edt_ft5x06_pins &edt_ft5x06_wake_pin>;
> > + interrupt-parent = <&gpio0>;
> > + interrupts = <19 IRQ_TYPE_EDGE_RISING>;
> > + reset-gpios = <&gpio0 21 GPIO_ACTIVE_LOW>;
> > + wake-gpios = <&gpio0 18 GPIO_ACTIVE_HIGH>;
> > + };
> > +};
> > +
> > +&lradc {
> > + status = "okay";
> > +};
> > +
> > +&mac0 {
> > + phy-mode = "rmii";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&mac0_pins_a>;
> > + phy-supply = <®_fec_3v3>;
> > + phy-handle = <ðphy>;
> > + status = "okay";
> > +
> > + mdio {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + ethphy: ethernet-phy@0 {
> > + compatible = "ethernet-phy-ieee802.3-c22";
> > + reg = <0>;
> > + max-speed = <100>;
> > + reset-gpios = <&gpio3 28 GPIO_ACTIVE_LOW>;
> > + reset-assert-us = <4000>;
> > + reset-deassert-us = <4000>;
> > + };
> > + };
> > +};
> > +
> > +&pinctrl {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&hog_pins_a>;
> > +
> > + hog_pins_a: hog@0 {
> > + reg = <0>;
> > + fsl,pinmux-ids = <
> > + MX28_PAD_SSP2_SS1__GPIO_2_20 /* External power */
> > + >;
> > + fsl,drive-strength = <MXS_DRIVE_4mA>;
> > + fsl,voltage = <MXS_VOLTAGE_HIGH>;
> > + fsl,pull-up = <MXS_PULL_DISABLE>;
> > + };
> > +
> > + edt_ft5x06_pins: edt-ft5x06@0 {
> > + reg = <0>;
> > + fsl,pinmux-ids = <
> > + MX28_PAD_GPMI_RDY1__GPIO_0_21 /* Reset */
> > + MX28_PAD_GPMI_CE3N__GPIO_0_19 /* Interrupt */
> > + >;
> > + fsl,drive-strength = <MXS_DRIVE_4mA>;
> > + fsl,voltage = <MXS_VOLTAGE_HIGH>;
> > + fsl,pull-up = <MXS_PULL_ENABLE>;
> > + };
> > +
> > + edt_ft5x06_wake_pin: edt-ft5x06-wake@0 {
> > + reg = <0>;
> > + fsl,pinmux-ids = <MX28_PAD_GPMI_CE2N__GPIO_0_18>;
> > + fsl,drive-strength = <MXS_DRIVE_16mA>;
> > + fsl,voltage = <MXS_VOLTAGE_HIGH>;
> > + fsl,pull-up = <MXS_PULL_DISABLE>;
> > + };
> > +
> > + fec_3v3_enable_pin: fec-3v3-enable@0 {
> > + reg = <0>;
> > + fsl,pinmux-ids = <MX28_PAD_SPDIF__GPIO_3_27>;
> > + fsl,drive-strength = <MXS_DRIVE_4mA>;
> > + fsl,voltage = <MXS_VOLTAGE_HIGH>;
> > + fsl,pull-up = <MXS_PULL_DISABLE>;
> > + };
> > +
> > + leds_pins: leds@0 {
> > + reg = <0>;
> > + fsl,pinmux-ids = <
> > + MX28_PAD_SSP0_DATA7__GPIO_2_7
> > + MX28_PAD_PWM0__GPIO_3_16
> > + MX28_PAD_PWM1__GPIO_3_17
> > + >;
> > + fsl,drive-strength = <MXS_DRIVE_4mA>;
> > + fsl,voltage = <MXS_VOLTAGE_HIGH>;
> > + fsl,pull-up = <MXS_PULL_DISABLE>;
> > + };
> > +
> > + usb0_vbus_enable_pin: usb0-vbus-enable@0 {
> > + reg = <0>;
> > + fsl,pinmux-ids = <MX28_PAD_SSP0_DATA5__GPIO_2_5>;
> > + fsl,drive-strength = <MXS_DRIVE_4mA>;
> > + fsl,voltage = <MXS_VOLTAGE_HIGH>;
> > + fsl,pull-up = <MXS_PULL_DISABLE>;
> > + };
> > +
> > + usb1_vbus_enable_pin: usb1-vbus-enable@0 {
> > + reg = <0>;
> > + fsl,pinmux-ids = <MX28_PAD_SSP0_DATA6__GPIO_2_6>;
> > + fsl,drive-strength = <MXS_DRIVE_4mA>;
> > + fsl,voltage = <MXS_VOLTAGE_HIGH>;
> > + fsl,pull-up = <MXS_PULL_DISABLE>;
> > + };
> > +};
> > +
> > +&pwm {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pwm4_pins_a &pwm7_pins_a>;
> > + status = "okay";
> > +};
> > +
> > +&ssp0 {
> > + compatible = "fsl,imx28-mmc";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&mmc0_4bit_pins_a &mmc0_sck_cfg>;
> > + status = "okay";
> > + bus-width = <4>;
> > + broken-cd;
> > +};
> > +
> > +&usb0 {
> > + status = "okay";
> > + vbus-supply = <®_usb0_vbus>;
> > + dr_mode = "host";
> > +};
> > +
> > +&usb1 {
> > + status = "okay";
> > + vbus-supply = <®_usb1_vbus>;
> > + dr_mode = "host";
> > +};
> > +
> > +&usbphy0 {
> > + status = "okay";
> > +};
> > +
> > +&usbphy1 {
> > + status = "okay";
> > +};
> > --
> > 2.43.0
> >
--
Dario Binacchi
Senior Embedded Linux Developer
dario.binacchi@...rulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@...rulasolutions.com
www.amarulasolutions.com
Powered by blists - more mailing lists