linux-kernel - Re: [PATCH 4/8] ASoC: codecs: wcd934x: Drop unused num_rx_port/num_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3ea3e51-2bd1-4155-906e-a39b35ec693b@gmail.com>
Date: Thu, 29 May 2025 10:29:29 +0100
From: Srinivas Kandagatla <srini.kernel@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 David Rhodes <david.rhodes@...rus.com>,
 Richard Fitzgerald <rf@...nsource.cirrus.com>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Support Opensource <support.opensource@...semi.com>,
 Oder Chiou <oder_chiou@...ltek.com>, Srinivas Kandagatla <srini@...nel.org>,
 Shengjiu Wang <shengjiu.wang@...il.com>, Xiubo Li <Xiubo.Lee@...il.com>,
 Fabio Estevam <festevam@...il.com>, Nicolin Chen <nicoleotsuka@...il.com>
Cc: linux-sound@...r.kernel.org, patches@...nsource.cirrus.com,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 4/8] ASoC: codecs: wcd934x: Drop unused
 num_rx_port/num_tx_port fields



On 5/28/25 8:59 PM, Krzysztof Kozlowski wrote:
> Members wcd934x_codec.num_rx_port and num_tx_port are not read anywhere
> after assignment, so they can be safely dropped.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>

--srini
>  sound/soc/codecs/wcd934x.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c
> index fa69817c97eaf1bf226b140f3a89095a50a128b2..1bb7e1dc7e6b0a5528cbdb7ada943a7d417fb684 100644
> --- a/sound/soc/codecs/wcd934x.c
> +++ b/sound/soc/codecs/wcd934x.c
> @@ -537,8 +537,6 @@ struct wcd934x_codec {
>  	int rate;
>  	u32 version;
>  	u32 hph_mode;
> -	int num_rx_port;
> -	int num_tx_port;
>  	u32 tx_port_value[WCD934X_TX_MAX];
>  	u32 rx_port_value[WCD934X_RX_MAX];
>  	int sido_input_src;
> @@ -1928,13 +1926,11 @@ static int wcd934x_set_channel_map(struct snd_soc_dai *dai,
>  		return -EINVAL;
>  	}
>  
> -	wcd->num_rx_port = rx_num;
>  	for (i = 0; i < rx_num; i++) {
>  		wcd->rx_chs[i].ch_num = rx_slot[i];
>  		INIT_LIST_HEAD(&wcd->rx_chs[i].list);
>  	}
>  
> -	wcd->num_tx_port = tx_num;
>  	for (i = 0; i < tx_num; i++) {
>  		wcd->tx_chs[i].ch_num = tx_slot[i];
>  		INIT_LIST_HEAD(&wcd->tx_chs[i].list);
>