linux-kernel - Re: [PATCH] mfd: Constify reg_sequence and regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDgyEzasBUfzAPj0@opensource.cirrus.com>
Date: Thu, 29 May 2025 11:08:19 +0100
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: James Ogletree <jogletre@...nsource.cirrus.com>,
        Fred Treven <fred.treven@...rus.com>,
        Ben Bright <ben.bright@...rus.com>, Lee Jones <lee@...nel.org>,
        Matti Vaittinen <mazziesaccount@...il.com>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        Andreas Kemnade <andreas@...nade.info>,
        Kevin Hilman <khilman@...libre.com>, Roger Quadros <rogerq@...nel.org>,
        Tony Lindgren <tony@...mide.com>, patches@...nsource.cirrus.com,
        linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH] mfd: Constify reg_sequence and regmap_irq

On Wed, May 28, 2025 at 09:44:17PM +0200, Krzysztof Kozlowski wrote:
> Static 'struct reg_sequence' array, 'struct regmap_irq_sub_irq_map' and
> 'struct regmap_irq_chip ' are not modified so can be changed to const
> for more safety.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/mfd/cs40l50-core.c | 2 +-
>
> -static struct regmap_irq_chip cs40l50_irq_chip = {
> +static const struct regmap_irq_chip cs40l50_irq_chip = {
>  	.name =		"cs40l50",
>  	.status_base =	CS40L50_IRQ1_INT_1,
>  	.mask_base =	CS40L50_IRQ1_MASK_1,

For the cs40l50:

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles