linux-kernel - Re: [PATCH] mm: Fix vmstat after removing NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd3307c0-4af5-4477-9258-2eec57c7003d@kernel.dk>
Date: Thu, 29 May 2025 04:43:54 -0600
From: Jens Axboe <axboe@...nel.dk>
To: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 David Hildenbrand <david@...hat.com>
Cc: lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com, vbabka@...e.cz,
 rppt@...nel.org, surenb@...gle.com, mhocko@...e.com, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, Hongyu Ning <hongyu.ning@...ux.intel.com>,
 stable@...r.kernel.org, Christoph Hellwig <hch@....de>,
 Hannes Reinecke <hare@...e.de>,
 Johannes Thumshirn <johannes.thumshirn@....com>
Subject: Re: [PATCH] mm: Fix vmstat after removing NR_BOUNCE

On 5/29/25 4:38 AM, Kirill A. Shutemov wrote:
> Hongyu noticed that the nr_unaccepted counter kept growing even in the
> absence of unaccepted memory on the machine.
> 
> This happens due to a commit that removed NR_BOUNCE: it removed the
> counter from the enum zone_stat_item, but left it in the vmstat_text
> array.
> 
> As a result, all counters below nr_bounce in /proc/vmstat are
> shifted by one line, causing the numa_hit counter to be labeled as
> nr_unaccepted.
> 
> To fix this issue, remove nr_bounce from the vmstat_text array.

Reviewed-by: Jens Axboe <axboe@...nel.dk>

> Cc: stable@...r.kernel.org

No need for a stable tag, the patch went into the 6.16 merge window.

-- 
Jens Axboe