linux-kernel - Re: [PATCH 15/15] x86/percpu: Remove !CONFIG_X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAFULd4YEYOXY+kud-arKGb_1aSV0y_skL==vUh6W8S8PYL_OXA@mail.gmail.com>
Date: Thu, 29 May 2025 14:45:08 +0200
From: Uros Bizjak <ubizjak@...il.com>
To: Ingo Molnar <mingo@...nel.org>
Cc: linux-kernel@...r.kernel.org, "Ahmed S . Darwish" <darwi@...utronix.de>, 
	Andrew Cooper <andrew.cooper3@...rix.com>, Ard Biesheuvel <ardb@...nel.org>, 
	Arnd Bergmann <arnd@...nel.org>, Borislav Petkov <bp@...en8.de>, 
	Dave Hansen <dave.hansen@...ux.intel.com>, "H . Peter Anvin" <hpa@...or.com>, 
	John Ogness <john.ogness@...utronix.de>, Linus Torvalds <torvalds@...ux-foundation.org>, 
	Peter Zijlstra <peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 15/15] x86/percpu: Remove !CONFIG_X86_CX8 methods

On Thu, May 15, 2025 at 10:58 AM Ingo Molnar <mingo@...nel.org> wrote:
>
> From: Uros Bizjak <ubizjak@...il.com>
>
> Adjust the constraints to the non-alternatives asm() statement.
>
> Signed-off-by: Uros Bizjak <ubizjak@...il.com>
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> Cc: "Ahmed S . Darwish" <darwi@...utronix.de>
> Cc: Andrew Cooper <andrew.cooper3@...rix.com>
> Cc: Ard Biesheuvel <ardb@...nel.org>
> Cc: Arnd Bergmann <arnd@...nel.org>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: "H . Peter Anvin" <hpa@...or.com>
> Cc: John Ogness <john.ogness@...utronix.de>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Link: https://lore.kernel.org/r/15696bb3-126b-ef71-f838-80e1e1c1b0aa@gmail.com
> ---
>  arch/x86/include/asm/percpu.h | 24 +++++++++---------------
>  1 file changed, 9 insertions(+), 15 deletions(-)
>
> diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/percpu.h
> index b0d03b6c279b..64c2e715af63 100644
> --- a/arch/x86/include/asm/percpu.h
> +++ b/arch/x86/include/asm/percpu.h
> @@ -335,13 +335,10 @@ do {                                                                      \
>         old__.var = _oval;                                              \
>         new__.var = _nval;                                              \
>                                                                         \
> -       asm_inline qual (                                               \
> -               ALTERNATIVE("call this_cpu_cmpxchg8b_emu",              \
> -                           "cmpxchg8b " __percpu_arg([var]), X86_FEATURE_CX8) \
> -               : ALT_OUTPUT_SP([var] "+m" (__my_cpu_var(_var)),        \
> -                               "+a" (old__.low), "+d" (old__.high))    \
> -               : "b" (new__.low), "c" (new__.high),                    \
> -                 "S" (&(_var))                                         \
> +       asm qual ("cmpxchg8b " __percpu_arg([var])                      \
> +               : "+m" (__my_cpu_var(_var)),                            \

Just noticed that the above line is missing a symbolic name for the
operand. This line should read:

               : [var] "+m" (__my_cpu_var(_var)),                            \

Uros.

> +                 "+a" (old__.low), "+d" (old__.high)                   \
> +               : "b" (new__.low), "c" (new__.high)                     \
>                 : "memory");                                            \
>                                                                         \
>         old__.var;                                                      \
> @@ -364,15 +361,12 @@ do {                                                                      \
>         old__.var = *_oval;                                             \
>         new__.var = _nval;                                              \
>                                                                         \
> -       asm_inline qual (                                               \
> -               ALTERNATIVE("call this_cpu_cmpxchg8b_emu",              \
> -                           "cmpxchg8b " __percpu_arg([var]), X86_FEATURE_CX8) \
> +       asm qual ("cmpxchg8b " __percpu_arg([var])                      \
>                 CC_SET(z)                                               \
> -               : ALT_OUTPUT_SP(CC_OUT(z) (success),                    \
> -                               [var] "+m" (__my_cpu_var(_var)),        \
> -                               "+a" (old__.low), "+d" (old__.high))    \
> -               : "b" (new__.low), "c" (new__.high),                    \
> -                 "S" (&(_var))                                         \
> +               : CC_OUT(z) (success),                                  \
> +                 [var] "+m" (__my_cpu_var(_var)),                      \
> +                 "+a" (old__.low), "+d" (old__.high)                   \
> +               : "b" (new__.low), "c" (new__.high)                     \
>                 : "memory");                                            \
>         if (unlikely(!success))                                         \
>                 *_oval = old__.var;                                     \
> --
> 2.45.2
>