linux-kernel - Re: [PATCH v3] rust: kunit: use crate-level mapping for `c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=X0m50+atjJWgVJpZb1pdOE8D+AiwFGsDmWCnOOtWfgw@mail.gmail.com>
Date: Thu, 29 May 2025 14:53:18 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Jesung Yang <y.j3ms.n@...il.com>
Cc: Brendan Higgins <brendan.higgins@...ux.dev>, David Gow <davidgow@...gle.com>, 
	Rae Moar <rmoar@...gle.com>, Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, linux-kselftest@...r.kernel.org, 
	kunit-dev@...glegroups.com, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] rust: kunit: use crate-level mapping for `c_void`

On Wed, May 28, 2025 at 7:51 PM Jesung Yang <y.j3ms.n@...il.com> wrote:
>
> Remove `use core::ffi::c_void`, which shadows `kernel::ffi::c_void`
> brought in via `use crate::prelude::*`, to maintain consistency and
> centralize the abstraction.
>
> Since `kernel::ffi::c_void` is a straightforward re-export of
> `core::ffi::c_void`, both are functionally equivalent. However, using
> `kernel::ffi::c_void` improves consistency across the kernel's Rust code
> and provides a unified reference point in case the definition ever needs
> to change, even if such a change is unlikely.
>
> Reviewed-by: Benno Lossin <lossin@...nel.org>
> Signed-off-by: Jesung Yang <y.j3ms.n@...il.com>
> Link: https://rust-for-linux.zulipchat.com/#narrow/channel/288089/topic/x/near/520452733

Looks good to me, thanks! If KUnit picks this next cycle:

Acked-by: Miguel Ojeda <ojeda@...nel.org>

Otherwise, I am happy to take it too.

Cheers,
Miguel