linux-kernel - Re: [PATCH] nfsd: Replace simple_strtoul with kstrtoint in expkey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d99618a-28a9-4ada-aba7-907f814bca76@nfschina.com>
Date: Thu, 29 May 2025 10:15:06 +0800
From: Su Hui <suhui@...china.com>
To: NeilBrown <neil@...wn.name>
Cc: chuck.lever@...cle.com, jlayton@...nel.org, okorniev@...hat.com,
 Dai.Ngo@...cle.com, tom@...pey.com, linux-nfs@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Su Hui <suhui@...china.com>
Subject: Re: [PATCH] nfsd: Replace simple_strtoul with kstrtoint in
 expkey_parse

On 2025/5/28 08:25, NeilBrown wrote:
> On Tue, 27 May 2025, Su Hui wrote:
>> kstrtoint() is better because simple_strtoul() ignores overflow and the
>> type of 'fsidtype' is 'int' rather than 'unsigned long'.
> Thanks for the patch.
>
> Reviewed-by: NeilBrown <neil@...wn.name>
>
> The valid values for fsidtype are actually 0-7 so it might be nice to
> change the type to u8 everywhere and make this kstrtou8() but that isn't
> really needed and shouldn't stop this patch landing.

Thanks for your suggestion.

  I can try this next week in a new patch because this has been merged
into nfsd-testing and I need some time to view code.

Su Hui