linux-kernel - Re: [PATCH] arch: arm64: dts: add big-endian property back into watchdog node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDiEpsIt0rJi1aRQ@lizhi-Precision-Tower-5810>
Date: Thu, 29 May 2025 12:00:38 -0400
From: Frank Li <Frank.li@....com>
To: "Li, Meng" <Meng.Li@...driver.com>
Cc: "shawnguo@...nel.org" <shawnguo@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back into
 watchdog node

On Thu, May 29, 2025 at 05:50:03AM +0000, Li, Meng wrote:
>
>
> > -----Original Message-----
> > From: Frank Li <Frank.li@....com>
> > Sent: Thursday, May 29, 2025 12:11 AM
> > To: Li, Meng <Meng.Li@...driver.com>
> > Cc: shawnguo@...nel.org; robh@...nel.org; conor+dt@...nel.org; linux-arm-
> > kernel@...ts.infradead.org; devicetree@...r.kernel.org; linux-
> > kernel@...r.kernel.org
> > Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back into
> > watchdog node
> >
> > CAUTION: This email comes from a non Wind River email account!
> > Do not click links or open attachments unless you recognize the sender and
> > know the content is safe.
> >
> > On Wed, May 28, 2025 at 07:17:51PM +0800, Meng Li wrote:
> > > When verifying watchdog feature on NXP ls1046ardb board, it doesn't
> > > work. Because the big-endian is deleted by accident, add it back.
> > >
> > > Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian for
> > > mmc nodes")
> >
> > fix tags should be wrong.
> >
> > I remember I tested without big-endian. If it is wrong, please revert original
> > patch and provide enough reason.
> >
>
> Although you said you understand my patch in your next email, do you think I still need to improve my commit log more clearly, and send a v2 patch?
> For example, describe that only the big-endian of watchdog node is remove by accident, and the mmc works fine. Only add the big-endian for watchdog feature.

Yes, you'd better descript why it is accident remove.

Frank
>
> Thanks,
> Limeng
>
> > Frank
> >
> > > Cc: stable@...r.kernel.org
> > > Signed-off-by: Meng Li <Meng.Li@...driver.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > index 4d75bff0d548..e15ec2e1cb04 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > @@ -753,6 +753,7 @@ wdog0: watchdog@...0000 {
> > >                       interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> > >                       clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
> > >                                           QORIQ_CLK_PLL_DIV(2)>;
> > > +                     big-endian;
> > >               };
> > >
> > >               edma0: dma-controller@...0000 {
> > > --
> > > 2.34.1
> > >