linux-kernel - Re: [PATCH] iio: accel: fxls8962af: Fix use after free in fxls8962af_fifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeAOFXuxsiAEwJ=dMJ8NZsyA7E-h4L=2ZgpprdUXU2EUA@mail.gmail.com>
Date: Thu, 29 May 2025 21:16:26 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: David Lechner <dlechner@...libre.com>
Cc: Sean Nyekjaer <sean@...nix.com>, Jonathan Cameron <jic23@...nel.org>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] iio: accel: fxls8962af: Fix use after free in fxls8962af_fifo_flush

On Thu, May 29, 2025 at 7:02 PM David Lechner <dlechner@...libre.com> wrote:
> On 5/24/25 5:34 AM, Sean Nyekjaer wrote:

...

> fxls8962af_suspend() calls enable_irq_wake(data->irq); before disabling the
> interrupt by calling fxls8962af_buffer_predisable(indio_dev);
>
> It seems like the order should be reversed.

AFAIU the wake capability of IRQ line is orthogonal to the interrupt
controller enabling (unmasking) / disabling (masking) the line itself.
Or did you mean something else?

-- 
With Best Regards,
Andy Shevchenko