linux-kernel - Re: [PATCH 2/2] hfs: make splice write available again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <604cca238cdecbbe3dee499b8363f31ddd9e63bc.camel@ibm.com>
Date: Thu, 29 May 2025 18:28:19 +0000
From: Viacheslav Dubeyko <Slava.Dubeyko@....com>
To: "frank.li@...o.com" <frank.li@...o.com>,
        "glaubitz@...sik.fu-berlin.de"
	<glaubitz@...sik.fu-berlin.de>,
        "slava@...eyko.com" <slava@...eyko.com>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
        "kees@...nel.org"
	<kees@...nel.org>
CC: "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re:  [PATCH 2/2] hfs: make splice write available again

On Thu, 2025-05-29 at 08:00 -0600, Yangtao Li wrote:
> Since 5.10, splice() or sendfile() return EINVAL. This was
> caused by commit 36e2c7421f02 ("fs: don't allow splice read/write
> without explicit ops").
> 
> This patch initializes the splice_write field in file_operations, like
> most file systems do, to restore the functionality.
> 
> Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
> Signed-off-by: Yangtao Li <frank.li@...o.com>
> ---
>  fs/hfs/inode.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c
> index a81ce7a740b9..451115360f73 100644
> --- a/fs/hfs/inode.c
> +++ b/fs/hfs/inode.c
> @@ -692,6 +692,7 @@ static const struct file_operations hfs_file_operations = {
>  	.write_iter	= generic_file_write_iter,
>  	.mmap		= generic_file_mmap,
>  	.splice_read	= filemap_splice_read,
> +	.splice_write	= iter_file_splice_write,
>  	.fsync		= hfs_file_fsync,
>  	.open		= hfs_file_open,
>  	.release	= hfs_file_release,

Makes sense.

Reviewed-by: Viacheslav Dubeyko <slava@...eyko.com>

Thanks,
Slava.