linux-kernel - Re: [PATCH v9 09/12] iio: adc: ad7768-1: add support for Synchronization over SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250530170922.000019a5@huawei.com>
Date: Fri, 30 May 2025 17:09:22 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Jonathan Santos <Jonathan.Santos@...log.com>
CC: <linux-iio@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
	<linux-acpi@...r.kernel.org>, <andy@...nel.org>, <nuno.sa@...log.com>,
	<Michael.Hennerich@...log.com>, <marcelo.schmitt@...log.com>,
	<jic23@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
	<conor+dt@...nel.org>, <marcelo.schmitt1@...il.com>,
	<linus.walleij@...aro.org>, <brgl@...ev.pl>, <lgirdwood@...il.com>,
	<broonie@...nel.org>, <jonath4nns@...il.com>, <dlechner@...libre.com>,
	<andriy.shevchenko@...ux.intel.com>, <rafael@...nel.org>,
	<djrscally@...il.com>
Subject: Re: [PATCH v9 09/12] iio: adc: ad7768-1: add support for
 Synchronization over SPI

On Thu, 29 May 2025 19:50:29 -0300
Jonathan Santos <Jonathan.Santos@...log.com> wrote:

> The synchronization method using GPIO requires the generated pulse to be
> truly synchronous with the base MCLK signal. When it is not possible to
> do that in hardware, the datasheet recommends using synchronization over
> SPI, where the generated pulse is already synchronous with MCLK. This
> requires the SYNC_OUT pin to be connected to the SYNC_IN pin.
> 
> Use trigger-sources property to enable device synchronization over SPI
> and multi-device synchronization while replacing sync-in-gpios property.
> 
> Reviewed-by: David Lechner <dlechner@...libre.com>
> Signed-off-by: Jonathan Santos <Jonathan.Santos@...log.com>

A couple of trivial comments.  Not enough to respin unless something else comes
up.


> @@ -296,6 +301,27 @@ static const struct regmap_config ad7768_regmap24_config = {
>  	.max_register = AD7768_REG24_COEFF_DATA,
>  };
>  
> +static int ad7768_send_sync_pulse(struct ad7768_state *st)
> +{
> +	if (st->en_spi_sync)
> +		return regmap_write(st->regmap, AD7768_REG_SYNC_RESET, 0x00);
> +
> +	/*
> +	 * The datasheet specifies a minimum SYNC_IN pulse width of 1.5 × Tmclk,
> +	 * where Tmclk is the MCLK period. The supported MCLK frequencies range
> +	 * from 0.6 MHz to 17 MHz, which corresponds to a minimum SYNC_IN pulse
> +	 * width of approximately 2.5 µs in the worst-case scenario (0.6 MHz).
> +	 *
> +	 * Add a delay to ensure the pulse width is always sufficient to
> +	 * trigger synchronization.
> +	 */
> +	gpiod_set_value_cansleep(st->gpio_sync_in, 1);
> +	fsleep(3);
> +	gpiod_set_value_cansleep(st->gpio_sync_in, 0);

This change + comment should really have been in a separate patch
as there is always the potential someone might want to backport it.

> +
> +	return 0;
> +}
> +
>  static int ad7768_set_mode(struct ad7768_state *st,
>  			   enum ad7768_conv_mode mode)
>  {
> @@ -392,10 +418,7 @@ static int ad7768_set_dig_fil(struct ad7768_state *st,
>  		return ret;
>  
>  	/* A sync-in pulse is required every time the filter dec rate changes */
> -	gpiod_set_value(st->gpio_sync_in, 1);
> -	gpiod_set_value(st->gpio_sync_in, 0);
> -
> -	return 0;
> +	return ad7768_send_sync_pulse(st);
>  }

> +
> +static int ad7768_trigger_sources_get_sync(struct device *dev,
> +					   struct ad7768_state *st)
> +{
> +	struct fwnode_handle *dev_fwnode = dev_fwnode(dev);
> +
> +	/*
> +	 * The AD7768-1 allows two primary methods for driving the SYNC_IN pin
> +	 * to synchronize one or more devices:
> +	 * 1. Using an external GPIO.
> +	 * 2. Using a SPI command, where the SYNC_OUT pin generates a
> +	 *    synchronization pulse that drives the SYNC_IN pin.
> +	 */
> +	if (fwnode_property_present(dev_fwnode, "trigger-sources"))
> +		return ad7768_trigger_sources_sync_setup(dev, dev_fwnode, st);
> +
> +	/*
> +	 * In the absence of trigger-sources property, enable self
> +	 * synchronization over SPI (SYNC_OUT).
> +	 */
> +	st->en_spi_sync = true;

Really trivial but if you respin for some reason blank line here.

> +	return 0;
> +}