linux-kernel - Re: [RFC v1] dt-bindings: interconnect: add mt7988-cci compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C75720B1-AD09-4A48-98FD-7FD8116934F7@fw-web.de>
Date: Fri, 30 May 2025 18:11:58 +0200
From: Frank Wunderlich <linux@...web.de>
To: Conor Dooley <conor@...nel.org>
CC: MyungJoo Ham <myungjoo.ham@...sung.com>,
 Kyungmin Park <kyungmin.park@...sung.com>,
 Chanwoo Choi <cw00.choi@...sung.com>, Georgi Djakov <djakov@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Jia-Wei Chang <jia-wei.chang@...iatek.com>,
 Johnson Wang <johnson.wang@...iatek.com>,
 Frank Wunderlich <frank-w@...lic-files.de>, linux-pm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [RFC v1] dt-bindings: interconnect: add mt7988-cci compatible

Hi

Thank you for review.

Am 30. Mai 2025 17:57:20 MESZ schrieb Conor Dooley <conor@...nel.org>:
>On Wed, May 28, 2025 at 03:52:49PM +0200, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@...lic-files.de>
>> 
>> Add compatible for Mediatek MT7988 SoC with mediatek,mt8183-cci fallback
>> which is taken by driver.
>
>What's RFC about the patch?

We have merge window,but maybe this rule is
net(-next) only. And i was unsure if enum for
new compatible is right or if i should use 2
const.

>> 
>> Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
>> ---
>>  .../bindings/interconnect/mediatek,cci.yaml          | 12 +++++++++---
>>  1 file changed, 9 insertions(+), 3 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml b/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
>> index 58611ba2a0f4..2c6785c588e9 100644
>> --- a/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
>> +++ b/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
>> @@ -17,9 +17,15 @@ description: |
>>  
>>  properties:
>>    compatible:
>> -    enum:
>> -      - mediatek,mt8183-cci
>> -      - mediatek,mt8186-cci
>> +    oneOf:
>> +      - items:
>
>This "- items:" is redundant.

Ok,i try without it.

>> +          - enum:
>> +              - mediatek,mt8183-cci
>> +              - mediatek,mt8186-cci
>> +      - items:
>> +          - enum:
>> +              - mediatek,mt7988-cci
>> +          - const: mediatek,mt8183-cci
>>  
>>    clocks:
>>      items:
>> -- 
>> 2.43.0
>> 


regards Frank