[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8b56cf49cfed7a9edb6d16dd287be90817a140da.camel@ibm.com>
Date: Fri, 30 May 2025 16:30:23 +0000
From: Viacheslav Dubeyko <Slava.Dubeyko@....com>
To: "frank.li@...o.com" <frank.li@...o.com>,
"glaubitz@...sik.fu-berlin.de"
<glaubitz@...sik.fu-berlin.de>,
"slava@...eyko.com" <slava@...eyko.com>
CC: "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/3] hfs: correct superblock flags
On Fri, 2025-05-30 at 02:17 -0600, Yangtao Li wrote:
> We don't support atime updates of any kind,
> because hfs actually does not have atime.
>
> dirCrDat: LongInt; {date and time of creation}
> dirMdDat: LongInt; {date and time of last modification}
> dirBkDat: LongInt; {date and time of last backup}
>
> filCrDat: LongInt; {date and time of creation}
> filMdDat: LongInt; {date and time of last modification}
> filBkDat: LongInt; {date and time of last backup}
>
> Signed-off-by: Yangtao Li <frank.li@...o.com>
> ---
> fs/hfs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/hfs/super.c b/fs/hfs/super.c
> index fe09c2093a93..9fab84b157b4 100644
> --- a/fs/hfs/super.c
> +++ b/fs/hfs/super.c
> @@ -331,7 +331,7 @@ static int hfs_fill_super(struct super_block *sb, struct fs_context *fc)
> sbi->sb = sb;
> sb->s_op = &hfs_super_operations;
> sb->s_xattr = hfs_xattr_handlers;
> - sb->s_flags |= SB_NODIRATIME;
> + sb->s_flags |= SB_NOATIME;
I don't agree with this patch. From my point of view, SB_NODIRATIME flag is
associated with nodiratime mount option and SB_NOATIME is associated with
noatime mount option. I prefer to have it both.
Thanks,
Slava.
> mutex_init(&sbi->bitmap_lock);
>
> res = hfs_mdb_get(sb);
Powered by blists - more mailing lists