linux-kernel - Re: [PATCH v5 21/29] iommufd: Allow an input data_type via iommu_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDnmxLMHq+E9UnVw@Asurada-Nvidia>
Date: Fri, 30 May 2025 10:11:32 -0700
From: Nicolin Chen <nicolinc@...dia.com>
To: Jason Gunthorpe <jgg@...dia.com>
CC: <kevin.tian@...el.com>, <corbet@....net>, <will@...nel.org>,
	<bagasdotme@...il.com>, <robin.murphy@....com>, <joro@...tes.org>,
	<thierry.reding@...il.com>, <vdumpa@...dia.com>, <jonathanh@...dia.com>,
	<shuah@...nel.org>, <jsnitsel@...hat.com>, <nathan@...nel.org>,
	<peterz@...radead.org>, <yi.l.liu@...el.com>, <mshavit@...gle.com>,
	<praan@...gle.com>, <zhangzekun11@...wei.com>, <iommu@...ts.linux.dev>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-tegra@...r.kernel.org>,
	<linux-kselftest@...r.kernel.org>, <patches@...ts.linux.dev>,
	<mochs@...dia.com>, <alok.a.tiwari@...cle.com>, <vasant.hegde@....com>,
	<dwmw2@...radead.org>, <baolu.lu@...ux.intel.com>
Subject: Re: [PATCH v5 21/29] iommufd: Allow an input data_type via
 iommu_hw_info

On Fri, May 30, 2025 at 01:52:18PM -0300, Jason Gunthorpe wrote:
> On Sat, May 17, 2025 at 08:21:38PM -0700, Nicolin Chen wrote:
> > @@ -666,7 +678,7 @@ struct iommu_hw_info {
> >  	__u32 dev_id;
> >  	__u32 data_len;
> >  	__aligned_u64 data_uptr;
> > -	__u32 out_data_type;
> > +	__u32 data_type;
> 
> It would be better to avoid changing this name, maybe stick a union
> around it?

Yes. I think a union is nicer.

Thanks!
Nicolin