[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250530182723.GW233377@nvidia.com>
Date: Fri, 30 May 2025 15:27:23 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Nicolin Chen <nicolinc@...dia.com>
Cc: kevin.tian@...el.com, corbet@....net, will@...nel.org,
bagasdotme@...il.com, robin.murphy@....com, joro@...tes.org,
thierry.reding@...il.com, vdumpa@...dia.com, jonathanh@...dia.com,
shuah@...nel.org, jsnitsel@...hat.com, nathan@...nel.org,
peterz@...radead.org, yi.l.liu@...el.com, mshavit@...gle.com,
praan@...gle.com, zhangzekun11@...wei.com, iommu@...ts.linux.dev,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org,
linux-kselftest@...r.kernel.org, patches@...ts.linux.dev,
mochs@...dia.com, alok.a.tiwari@...cle.com, vasant.hegde@....com
Subject: Re: [PATCH v4 05/23] iommufd/driver: Let iommufd_viommu_alloc helper
save ictx to viommu->ictx
On Tue, May 27, 2025 at 11:41:19AM -0700, Nicolin Chen wrote:
> On Mon, May 26, 2025 at 10:30:46AM -0300, Jason Gunthorpe wrote:
> > On Fri, May 16, 2025 at 01:56:26PM -0700, Nicolin Chen wrote:
> >
> > > > You don't need to move this unless you are using inlines. Just use a
> > > > forward declaration.
> > >
> > > Since we forward ucmd now, ictx is in the ucmd so we need this
> > > structure for:
> > >
> > > - if (!IS_ERR(ret)) \
> > > + if (!IS_ERR(ret)) { \
> > > ret->member.ops = viommu_ops; \
> > > + ret->member.ictx = ucmd->ictx; \
> > > + } \
> >
> > De-inline more of that function probably..
> >
> > Also seem my other remarks about not storing ictx so much..
>
> I found that all other ictx pointers in vdev/hw_queue are unused,
> as the core simply gets an ictx from their viommu pointers. This
> means that only this viommu allocator here needs such a storing.
>
> With that, how about a change like this v.s. inline:
So I think the other suggestion with init vs alloc supersedes this and
makes it all pretty clean?
Jason
Powered by blists - more mailing lists