linux-kernel - Re: [PATCH v2] fsdax: Remove unused trace events for dax insert mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDkgo81JQykBKCY6@aschofie-mobl2.lan>
Date: Thu, 29 May 2025 20:06:11 -0700
From: Alison Schofield <alison.schofield@...el.com>
To: Steven Rostedt <rostedt@...dmis.org>
CC: LKML <linux-kernel@...r.kernel.org>, Linux Trace Kernel
	<linux-trace-kernel@...r.kernel.org>, <nvdimm@...ts.linux.dev>, Dan Williams
	<dan.j.williams@...el.com>, Shiyang Ruan <ruansy.fnst@...itsu.com>, "Darrick
 J. Wong" <djwong@...nel.org>, Ross Zwisler <zwisler@...nel.org>, "Andrew
 Morton" <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] fsdax: Remove unused trace events for dax insert
 mapping

On Thu, May 29, 2025 at 03:22:11PM -0400, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@...dmis.org>
> 
> When the dax_fault_actor() helper was factored out, it removed the calls
> to the dax_pmd_insert_mapping and dax_insert_mapping events but never
> removed the events themselves. As each event created takes up memory
> (roughly 5K each), this is a waste as it is never used.
> 
> Remove the unused dax_pmd_insert_mapping and dax_insert_mapping trace
> events.

Reviewed-by: Alison Schofield <alison.schofield@...el.com>

> 
> Link: https://lore.kernel.org/all/20250529130138.544ffec4@gandalf.local.home/
> 
> Fixes: c2436190e492 ("fsdax: factor out a dax_fault_actor() helper")
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> ---
> Changes since v1: https://lore.kernel.org/all/20250529150722.19e04332@gandalf.local.home/
> 
> - Removed dax_insert_mapping too
> 
>  include/trace/events/fs_dax.h | 78 -----------------------------------
>  1 file changed, 78 deletions(-)
>