linux-kernel - Re: [PATCH v4 06/10] accel/rocket: Add IOCTL for BO creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc0b88b2-c34a-4d19-a222-afc2cbfe8055@web.de>
Date: Fri, 30 May 2025 21:23:15 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Tomeu Vizoso <tomeu@...euvizoso.net>, dri-devel@...ts.freedesktop.org,
 linux-rockchip@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linaro-mm-sig@...ts.linaro.org, Christian König
 <christian.koenig@....com>, Conor Dooley <conor+dt@...nel.org>,
 David Airlie <airlied@...il.com>, Heiko Stübner
 <heiko@...ech.de>, Jeff Hugo <jeff.hugo@....qualcomm.com>,
 Jonathan Corbet <corbet@....net>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>,
 Nicolas Frattaroli <nicolas.frattaroli@...labora.com>,
 Oded Gabbay <ogabbay@...nel.org>, Rob Herring <robh@...nel.org>,
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 Simona Vetter <simona@...ll.ch>, Sumit Semwal <sumit.semwal@...aro.org>,
 Thomas Zimmermann <tzimmermann@...e.de>
Cc: LKML <linux-kernel@...r.kernel.org>, linux-doc@...r.kernel.org
Subject: Re: [PATCH v4 06/10] accel/rocket: Add IOCTL for BO creation

…
> +++ b/drivers/accel/rocket/rocket_gem.c
> @@ -0,0 +1,131 @@
…
> +static void rocket_gem_bo_free(struct drm_gem_object *obj)
> +{
…
> +	mutex_lock(&rdev->iommu_lock);
> +
> +	sgt = drm_gem_shmem_get_pages_sgt(&bo->base);
…
> +	drm_gem_shmem_free(&bo->base);
> +
> +	mutex_unlock(&rdev->iommu_lock);
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&rdev->iommu_lock);”?
https://elixir.bootlin.com/linux/v6.15/source/include/linux/mutex.h#L201

Regards,
Markus