linux-kernel - Re: [PATCH] smb/client: use sock_create_kern() in generic_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250530031036.3221187-1-kuni1840@gmail.com>
Date: Thu, 29 May 2025 20:10:05 -0700
From: Kuniyuki Iwashima <kuni1840@...il.com>
To: chenxiaosong@...nxiaosong.com
Cc: bharathsm@...rosoft.com,
	chenxiaosong@...inos.cn,
	david.laight.linux@...il.com,
	ematsumiya@...e.de,
	kuniyu@...zon.com,
	linux-cifs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	pc@...guebit.com,
	ronniesahlberg@...il.com,
	smfrench@...il.com,
	sprasad@...rosoft.com,
	tom@...pey.com,
	wangzhaolong1@...wei.com
Subject: Re: [PATCH] smb/client: use sock_create_kern() in generic_ip_connect()

Thanks for CCing me, Steve.

From: ChenXiaoSong <chenxiaosong@...nxiaosong.com>
Date: Wed, 28 May 2025 12:09:01 +0800
> This patch is simply a cleanup that wraps the original code for 
> explicitness, the last argument of __sock_create(..., 1) specifies that 
> the socket is created in kernel space.

Not sure how you came up with this patch, maybe coincidence, but
I'm trying to clean these up at once on the netdev side, so it would
be appreciated if this is kept as is to avoid unnecessary conflicts.

https://lore.kernel.org/netdev/20250523182128.59346-2-kuniyu@amazon.com/


> 
> 在 2025/5/28 11:39, Steve French 写道:
> > Weren't there issues brought up earlier with using sock_create_kern
> > due to network namespaces and refcounts?
> > 
> > On Tue, May 27, 2025 at 10:18 PM <chenxiaosong@...nxiaosong.com> wrote:
> >>
> >> From: ChenXiaoSong <chenxiaosong@...inos.cn>
> >>
> >> Change __sock_create() to sock_create_kern() for explicitness.
> >>
> >> Signed-off-by: ChenXiaoSong <chenxiaosong@...inos.cn>
> >> ---
> >>   fs/smb/client/connect.c | 3 +--
> >>   1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/fs/smb/client/connect.c b/fs/smb/client/connect.c
> >> index 6bf04d9a5491..3275f2ff84cb 100644
> >> --- a/fs/smb/client/connect.c
> >> +++ b/fs/smb/client/connect.c
> >> @@ -3350,8 +3350,7 @@ generic_ip_connect(struct TCP_Server_Info *server)
> >>                  struct net *net = cifs_net_ns(server);
> >>                  struct sock *sk;
> >>
> >> -               rc = __sock_create(net, sfamily, SOCK_STREAM,
> >> -                                  IPPROTO_TCP, &server->ssocket, 1);
> >> +               rc = sock_create_kern(net, sfamily, SOCK_STREAM, IPPROTO_TCP, &server->ssocket);
> >>                  if (rc < 0) {
> >>                          cifs_server_dbg(VFS, "Error %d creating socket\n", rc);
> >>                          return rc;
> >> --
> >> 2.34.1
> >>
> >>
> > 
> >