| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <pxo635637l45rxb5fgnmopq5jbs7lp2hd736mwrqt6jfgvw75g@kmc7rqxu6oyh>
Date: Fri, 30 May 2025 23:09:05 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Jessica Zhang <jessica.zhang@....qualcomm.com>
Cc: Rob Clark <robdclark@...il.com>, Abhinav Kumar <quic_abhinavk@...cinc.com>,
Sean Paul <sean@...rly.run>,
Marijn Suijten <marijn.suijten@...ainline.org>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Kuogee Hsieh <quic_khsieh@...cinc.com>,
Abel Vesa <abel.vesa@...aro.org>,
Bjorn Andersson <andersson@...nel.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, Mahadevan <quic_mahap@...cinc.com>,
Krishna Manikandan <quic_mkrishn@...cinc.com>,
Konrad Dybcio <konradybcio@...nel.org>,
Danila Tikhonov <danila@...xyga.com>, linux-arm-msm@...r.kernel.org,
dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-clk@...r.kernel.org, Yongxing Mou <quic_yongmou@...cinc.com>
Subject: Re: [PATCH v2 3/5] dt-bindings: display/msm: drop
assigned-clock-parents for dp controller
On Fri, May 30, 2025 at 10:47:26AM -0700, Jessica Zhang wrote:
> From: Abhinav Kumar <quic_abhinavk@...cinc.com>
>
> Current documentation of assigned-clock-parents for dp controller does not
> describe its functionality correctly making it harder to extend it for
> adding multiple streams.
>
> Instead of fixing up the documentation, drop the assigned-clock-parents
> along with the usages in the chipset specific MDSS yaml files.
Don't we need to drop assigned-clocks too? One doesn't really make sense
without another.
>
> Signed-off-by: Abhinav Kumar <quic_abhinavk@...cinc.com>
> Signed-off-by: Jessica Zhang <jessica.zhang@....qualcomm.com>
> ---
> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 7 -------
> .../devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 1 -
> .../devicetree/bindings/display/msm/qcom,sar2130p-mdss.yaml | 2 --
> .../devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml | 1 -
> .../devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml | 2 --
> .../devicetree/bindings/display/msm/qcom,sm7150-mdss.yaml | 2 --
> 6 files changed, 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index 46a50ca4a986..a63efd8de42c 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -74,11 +74,6 @@ properties:
> - description: link clock source
> - description: pixel clock source
>
> - assigned-clock-parents:
> - items:
> - - description: phy 0 parent
> - - description: phy 1 parent
> -
> phys:
> maxItems: 1
>
> @@ -208,8 +203,6 @@ examples:
> assigned-clocks = <&dispcc DISP_CC_MDSS_DP_LINK_CLK_SRC>,
> <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>;
>
> - assigned-clock-parents = <&dp_phy 0>, <&dp_phy 1>;
> -
> phys = <&dp_phy>;
> phy-names = "dp";
>
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> index 1053b3bc4908..951e446dc828 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> @@ -393,7 +393,6 @@ examples:
>
> assigned-clocks = <&dispcc_mdss_dptx0_link_clk_src>,
> <&dispcc_mdss_dptx0_pixel0_clk_src>;
> - assigned-clock-parents = <&mdss0_dp0_phy 0>, <&mdss0_dp0_phy 1>;
>
> phys = <&mdss0_dp0_phy>;
> phy-names = "dp";
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sar2130p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sar2130p-mdss.yaml
> index 870144b53cec..a1f5a6bd328e 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sar2130p-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sar2130p-mdss.yaml
> @@ -216,8 +216,6 @@ examples:
>
> assigned-clocks = <&dispcc_disp_cc_mdss_dptx0_link_clk_src>,
> <&dispcc_disp_cc_mdss_dptx0_pixel0_clk_src>;
> - assigned-clock-parents = <&usb_dp_qmpphy_QMP_USB43DP_DP_LINK_CLK>,
> - <&usb_dp_qmpphy_QMP_USB43DP_DP_VCO_DIV_CLK>;
>
> phys = <&usb_dp_qmpphy QMP_USB43DP_DP_PHY>;
> phy-names = "dp";
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
> index 7a0555b15ddf..f737a8481acb 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
> @@ -269,7 +269,6 @@ examples:
> "ctrl_link_iface", "stream_pixel";
> assigned-clocks = <&dispcc DISP_CC_MDSS_DP_LINK_CLK_SRC>,
> <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>;
> - assigned-clock-parents = <&dp_phy 0>, <&dp_phy 1>;
> phys = <&dp_phy>;
> phy-names = "dp";
>
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
> index 2947f27e0585..7842ef274258 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
> @@ -298,7 +298,6 @@ examples:
> "stream_pixel";
> assigned-clocks = <&dispcc DISP_CC_MDSS_EDP_LINK_CLK_SRC>,
> <&dispcc DISP_CC_MDSS_EDP_PIXEL_CLK_SRC>;
> - assigned-clock-parents = <&mdss_edp_phy 0>, <&mdss_edp_phy 1>;
>
> phys = <&mdss_edp_phy>;
> phy-names = "dp";
> @@ -389,7 +388,6 @@ examples:
> "stream_pixel";
> assigned-clocks = <&dispcc DISP_CC_MDSS_DP_LINK_CLK_SRC>,
> <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>;
> - assigned-clock-parents = <&dp_phy 0>, <&dp_phy 1>;
> phys = <&dp_phy>;
> phy-names = "dp";
>
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.yaml
> index 13c5d5ffabde..3cea87def9f8 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.yaml
> @@ -401,8 +401,6 @@ examples:
>
> assigned-clocks = <&dispcc_mdss_dp_link_clk_src>,
> <&dispcc_mdss_dp_pixel_clk_src>;
> - assigned-clock-parents = <&dp_phy 0>,
> - <&dp_phy 1>;
>
> operating-points-v2 = <&dp_opp_table>;
> power-domains = <&rpmhpd RPMHPD_CX>;
>
> --
> 2.49.0
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists