linux-kernel - Re: [PATCH 3/3] Input: ims-pcu - Check record size in ims_pcu_flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <brjna7vjgzn6fpbdoxwhzs4qonbs5dzqujpj3lufgkxetxlvvb@oyiz7m6cqltu>
Date: Fri, 30 May 2025 16:14:24 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Kees Cook <kees@...nel.org>, 
	Javier Carrasco <javier.carrasco.cruz@...il.com>, David Lechner <dlechner@...libre.com>, 
	"Gustavo A. R. Silva" <gustavoars@...nel.org>, Al Viro <viro@...iv.linux.org.uk>, 
	Erick Archer <erick.archer@...look.com>, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Input: ims-pcu - Check record size in
 ims_pcu_flash_firmware()

On Wed, May 28, 2025 at 11:22:24PM +0300, Dan Carpenter wrote:
> The "len" variable comes from the firmware and we generally do
> trust firmware, but it's always better to double check.  If the "len"
> is too large it could result in memory corruption when we do
> "memcpy(fragment->data, rec->data, len);"
> 
> Fixes: 628329d52474 ("Input: add IMS Passenger Control Unit driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Applied, thank you.

-- 
Dmitry