[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ad0301a0-f45f-900a-028d-dff5e08b9525@linux.intel.com>
Date: Fri, 30 May 2025 11:03:05 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Stuart Hayes <stuart.w.hayes@...il.com>
cc: LKML <linux-kernel@...r.kernel.org>, Hans de Goede <hdegoede@...hat.com>,
platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v3 3/4] platform/x86: dell_rbu: Stop overwriting data
buffer
On Thu, 29 May 2025, Stuart Hayes wrote:
> The dell_rbu driver will use memset() to clear the data held by each
> packet when it is no longer needed (when the driver is unloaded, the
> packet size is changed, etc).
>
> The amount of memory that is cleared (before this patch) is the normal
> packet size. However, the last packet in the list may be smaller.
>
> Fix this to only clear the memory actually used by each packet, to prevent
> it from writing past the end of data buffer.
>
> Signed-off-by: Stuart Hayes <stuart.w.hayes@...il.com>
This still doesn't have Fixes tag? If it writes part the buffer, there
certainly should be one in this one. Did you perhaps add it to a wrong
patch?
> ---
> drivers/platform/x86/dell/dell_rbu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/dell/dell_rbu.c
> index c03d4d55fcc1..7d5b26735a20 100644
> --- a/drivers/platform/x86/dell/dell_rbu.c
> +++ b/drivers/platform/x86/dell/dell_rbu.c
> @@ -322,7 +322,7 @@ static void packet_empty_list(void)
> * zero out the RBU packet memory before freeing
> * to make sure there are no stale RBU packets left in memory
> */
> - memset(newpacket->data, 0, rbu_data.packetsize);
> + memset(newpacket->data, 0, newpacket->length);
> set_memory_wb((unsigned long)newpacket->data,
> 1 << newpacket->ordernum);
> free_pages((unsigned long) newpacket->data,
>
--
i.
Powered by blists - more mailing lists