linux-kernel - Re: [PATCH] fat: correct superblock flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87v7piflc5.fsf@mail.parknet.co.jp>
Date: Fri, 30 May 2025 19:23:54 +0900
From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To: Yangtao Li <frank.li@...o.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fat: correct superblock flags

Yangtao Li <frank.li@...o.com> writes:

> SB_NOATIME includes SB_NODIRATIME as a subset. Therefore,
> setting SB_NOATIME is sufficient to disable atime updates
> for all files and directories.

SB_NODIRATIME is set at fat_fill_super(). So always SB_NODIRATIME looks
like it is consistent even if meaningless than removing only if remount.

Thanks.

> Signed-off-by: Yangtao Li <frank.li@...o.com>
> ---
>  fs/fat/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 3852bb66358c..5da96c37386d 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -807,7 +807,7 @@ int fat_reconfigure(struct fs_context *fc)
>  	bool new_rdonly;
>  	struct super_block *sb = fc->root->d_sb;
>  	struct msdos_sb_info *sbi = MSDOS_SB(sb);
> -	fc->sb_flags |= SB_NODIRATIME | (sbi->options.isvfat ? 0 : SB_NOATIME);
> +	fc->sb_flags |= sbi->options.isvfat ? SB_NODIRATIME : SB_NOATIME;
>  
>  	sync_filesystem(sb);

-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>