linux-kernel - Re: [PATCH] selftests/filesystems: Fix build of anon_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aDmKzSkIlOAkj_Bq@finisterre.sirena.org.uk>
Date: Fri, 30 May 2025 11:39:09 +0100
From: Mark Brown <broonie@...nel.org>
To: Shuah Khan <shuah@...nel.org>, Christian Brauner <brauner@...nel.org>,
	Jeff Layton <jlayton@...nel.org>,
	Amir Goldstein <amir73il@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Cc: linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/filesystems: Fix build of anon_inode_test

On Sun, May 18, 2025 at 03:01:34PM +0100, Mark Brown wrote:
> The anon_inode_test test fails to build due to attempting to include
> a nonexisting overlayfs/wrapper.h:
> 
> anon_inode_test.c:10:10: fatal error: overlayfs/wrappers.h: No such file or directory
>    10 | #include "overlayfs/wrappers.h"
>       |          ^~~~~~~~~~~~~~~~~~~~~~

This build failure, first reported against -next and which should be
fixed by this patch, is now present in mainline.

> This is due to 0bd92b9fe538 ("selftests/filesystems: move wrapper.h out
> of overlayfs subdir") which was added in the vfs-6.16.selftests branch
> which was based on -rc5 and does not contain the newly added test so
> once things were merged into vfs.all in the build started failing - both
> parent commits are fine.
> 
> Fixes: feaa00dbff45a ("Merge branch 'vfs-6.16.selftests' into vfs.all")

I see that the two branches get sent separately to Linus so the merge
that triggers things is now:

   3e406741b19890 ("Merge tag 'vfs-6.16-rc1.selftests' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs")

I'll resend with that updated.

> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>  tools/testing/selftests/filesystems/anon_inode_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/filesystems/anon_inode_test.c b/tools/testing/selftests/filesystems/anon_inode_test.c
> index e8e0ef1460d2..73e0a4d4fb2f 100644
> --- a/tools/testing/selftests/filesystems/anon_inode_test.c
> +++ b/tools/testing/selftests/filesystems/anon_inode_test.c
> @@ -7,7 +7,7 @@
>  #include <sys/stat.h>
>  
>  #include "../kselftest_harness.h"
> -#include "overlayfs/wrappers.h"
> +#include "wrappers.h"
>  
>  TEST(anon_inode_no_chown)
>  {
> 
> ---
> base-commit: feaa00dbff45ad9a0dcd04a92f88c745bf880f55
> change-id: 20250516-selftests-anon-inode-build-007e206e8422
> 
> Best regards,
> -- 
> Mark Brown <broonie@...nel.org>
> 

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)