linux-kernel - Re: [PATCH v3 2/2] arm64: dts: qcom: sa8775p: Remove max link speed property for PCIe EP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41ac26a6-7a5a-4c11-b05c-9ce688ad1856@oss.qualcomm.com>
Date: Fri, 30 May 2025 12:50:46 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Mrinmay Sarkar <mrinmay.sarkar@....qualcomm.com>,
        Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
        Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
        devicetree@...r.kernel.org, krishna.chundru@....qualcomm.com,
        quic_vbadigan@...cinc.com, quic_nayiluri@...cinc.com,
        quic_ramkri@...cinc.com, quic_nitegupt@...cinc.com,
        Mrinmay Sarkar <quic_msarkar@...cinc.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sa8775p: Remove max link speed
 property for PCIe EP

On 5/30/25 7:38 AM, Mrinmay Sarkar wrote:
> On Tue, May 27, 2025 at 4:06 PM Konrad Dybcio
> <konrad.dybcio@....qualcomm.com> wrote:
>>
>> On 5/25/25 3:29 PM, Dmitry Baryshkov wrote:
>>> On Sun, May 25, 2025 at 11:27:18AM +0530, Mrinmay Sarkar wrote:
>>>> From: Mrinmay Sarkar <mrinmay.sarkar@....qualcomm.com>
>>>>
>>>> The maximum link speed was previously restricted to Gen3 due to the
>>>> absence of Gen4 equalization support in the driver.
>>>>
>>>> Add change to remove max link speed property, Since Gen4 equalization
>>>> support has already been added into the driver.
>>>
>>> As Gen4 equalization is already supported by the XYZ driver remove the
>>> max-link-speed property.
>>>
>>> "Add change to remove" is a bit clumsy.
>>
>> I'm more worried about this node not having these gen4 eq settings
>> (i.e. the part talking about driver support landing is true, but it's
>> unused without the presets being explicitly defined in eq-presets-16gts)
>>
>> Konrad
> 
> Hi Konrad,
> 
> Actually stability issue was resolved by this patch series:
> https://lore.kernel.org/linux-pci/20240911-pci-qcom-gen4-stability-v7-3-743f5c1fd027@linaro.org/
> and I don't think we need to define eq-presets-16gts for this.

Okay, so there's multiple parts to it..

I was referring to this series

https://lore.kernel.org/all/20250328-preset_v6-v9-0-22cfa0490518@oss.qualcomm.com/

Please check if you need this as well

Konrad