linux-kernel - Re: [PATCH 2/2] Bluetooth: btrtl: Add enhanced download support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202505301910.8q5W0vf5-lkp@intel.com>
Date: Fri, 30 May 2025 19:49:28 +0800
From: kernel test robot <lkp@...el.com>
To: Hilda Wu <hildawu@...ltek.com>, marcel@...tmann.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	luiz.dentz@...il.com, linux-bluetooth@...r.kernel.org,
	linux-kernel@...r.kernel.org, max.chou@...ltek.com,
	alex_lu@...lsil.com.cn
Subject: Re: [PATCH 2/2] Bluetooth: btrtl: Add enhanced download support

Hi Hilda,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bluetooth/master]
[also build test WARNING on bluetooth-next/master linus/master v6.15 next-20250530]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Hilda-Wu/Bluetooth-btrtl-Firmware-format-v3-support/20250529-205020
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link:    https://lore.kernel.org/r/20250529124816.4186320-3-hildawu%40realtek.com
patch subject: [PATCH 2/2] Bluetooth: btrtl: Add enhanced download support
config: i386-buildonly-randconfig-004-20250530 (https://download.01.org/0day-ci/archive/20250530/202505301910.8q5W0vf5-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250530/202505301910.8q5W0vf5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505301910.8q5W0vf5-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/bluetooth/btrtl.c:1339:7: warning: format specifies type 'unsigned long' but the argument has type 'unsigned int' [-Wformat]
    1338 |                 bt_dev_err(hdev, "got invalid cmd complete, %u %lu", skb->len,
         |                                                                ~~~
         |                                                                %u
    1339 |                            sizeof(*ev));
         |                            ^~~~~~~~~~~
   include/net/bluetooth/bluetooth.h:280:42: note: expanded from macro 'bt_dev_err'
     280 |         BT_ERR("%s: " fmt, bt_dev_name(hdev), ##__VA_ARGS__)
         |                       ~~~                       ^~~~~~~~~~~
   include/net/bluetooth/bluetooth.h:265:45: note: expanded from macro 'BT_ERR'
     265 | #define BT_ERR(fmt, ...)        bt_err(fmt "\n", ##__VA_ARGS__)
         |                                        ~~~         ^~~~~~~~~~~
   drivers/bluetooth/btrtl.c:2071:1: error: function definition is not allowed here
    2071 | {
         | ^
   drivers/bluetooth/btrtl.c:2113:1: error: function definition is not allowed here
    2113 | {
         | ^
   drivers/bluetooth/btrtl.c:2172:1: error: function definition is not allowed here
    2172 | {
         | ^
   drivers/bluetooth/btrtl.c:2199:1: error: function definition is not allowed here
    2199 | {
         | ^
   drivers/bluetooth/btrtl.c:2219:1: error: function definition is not allowed here
    2219 | {
         | ^
   drivers/bluetooth/btrtl.c:2246:1: error: function definition is not allowed here
    2246 | {
         | ^
   drivers/bluetooth/btrtl.c:2286:1: error: function definition is not allowed here
    2286 | {
         | ^
   drivers/bluetooth/btrtl.c:2404:48: error: expected '}'
    2404 | MODULE_FIRMWARE("rtl_bt/rtl8922au_config.bin");
         |                                                ^
   drivers/bluetooth/btrtl.c:1878:1: note: to match this '{'
    1878 | {
         | ^
   1 warning and 8 errors generated.


vim +1339 drivers/bluetooth/btrtl.c

  1322	
  1323	static int btrtl_enhanced_download_mode_enable(struct hci_dev *hdev,
  1324						struct btrtl_device_info *btrtl_dev)
  1325	{
  1326		struct hci_rp_enhanced_download_mode *ev;
  1327		struct sk_buff *skb;
  1328		u16 opcode = 0xfc1f;
  1329		u8 val = 1;
  1330		int ret = -EINVAL;
  1331	
  1332		skb = __hci_cmd_sync(hdev, opcode, 1, &val, HCI_CMD_TIMEOUT);
  1333		if (IS_ERR(skb)) {
  1334			bt_dev_err(hdev, "send %04x error (%lu)", opcode, PTR_ERR(skb));
  1335			return -EIO;
  1336		}
  1337		if (skb->len != sizeof(*ev)) {
  1338			bt_dev_err(hdev, "got invalid cmd complete, %u %lu", skb->len,
> 1339				   sizeof(*ev));
  1340			goto err;
  1341		}
  1342		ev = (struct hci_rp_enhanced_download_mode *)skb->data;
  1343		if (ev->status) {
  1344			bt_dev_err(hdev, "got invalid status 0x%02x", ev->status);
  1345			goto err;
  1346		}
  1347		btrtl_dev->handle = le16_to_cpu(ev->handle);
  1348		btrtl_dev->acldata_pkt_len = le16_to_cpu(ev->acldata_pkt_len);
  1349		kfree_skb(skb);
  1350	
  1351		bt_dev_info(hdev, "enhanced download mode enabled, handle %04x, acl %u",
  1352			    btrtl_dev->handle, btrtl_dev->acldata_pkt_len);
  1353	
  1354		return 0;
  1355	err:
  1356		kfree_skb(skb);
  1357		return ret;
  1358	}
  1359	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki