linux-kernel - Re: [PATCH v2 0/4] media: rcar-csi2: Add D-PHY support for V4H

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <313e359f-460f-4c3e-b4bd-f3281673135d@ideasonboard.com>
Date: Fri, 30 May 2025 15:31:05 +0300
From: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
To: Niklas Söderlund
 <niklas.soderlund+renesas@...natech.se>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 linux-media@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] media: rcar-csi2: Add D-PHY support for V4H

Hi,

On 11/05/2025 20:47, Niklas Söderlund wrote:
> Hello,
> 
> This series adds support for CSI-2 D-PHY reception on R-Car Gen4 V4H
> devices. Previously only C-PHY reception due to poor documentation and
> no hardware to test D-PHY on.
> 
> Later revisions of the datasheet (Rev.1.21) describes the start-up
> procedure in some detail, and we now have hardware to test on! The
> documentation however only sparsely documents the registers involved and
> instead mostly document magic values and an order to write them to
> register offsets without much documentation.
> 
> This series tries to in the extend possible to at least used named
> register and use formulas and lookup tables to make some sens of the
> magic values. Still most of them comes of a table of magic values in the
> datasheet.
> 
> Patch 1/4 clears up a unfortunate mix of the name mbps (mega bits per
> second) used in the D-PHY context and msps (mega symbols per second)
> used in the C-PHY context.
> 
> Patch 2/4 and 3/4 prepares for adding D-PHY support by cleaning up
> register names and an updated common startup procedure for V4H which
> have been revised in later versions of the datasheet since the initial
> C-PHY V4H support was added.
> 
> Finally patch 4/4 adds D-PHY support.
> 
> The work is to great extent at many different link speed and number of
> lanes. In 2-lane mode using an IMX219 and in 4-lane mode using IMX462
> sensors.
> 
> See individual patches for change log.
> 
> Niklas Söderlund (4):
>   media: rcar-csi2: Clarify usage of mbps and msps
>   media: rcar-csi2: Rework macros to access AFE lanes
>   media: rcar-csi2: Update start procedure for V4H
>   media: rcar-csi2: Add D-PHY support for V4H
> 
>  drivers/media/platform/renesas/rcar-csi2.c | 447 ++++++++++++++++++---
>  1 file changed, 402 insertions(+), 45 deletions(-)
> 

On my V4H + GMSL multistream branch (i.e. C-PHY):

Tested-by: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>

 Tomi