linux-kernel - [PATCH AUTOSEL 6.15 14/30] ALSA: hda/realtek: Add support for Acer Helios Laptops using CS35L41 HDA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250530123852.2574030-14-sashal@kernel.org>
Date: Fri, 30 May 2025 08:38:36 -0400
From: Sasha Levin <sashal@...nel.org>
To: patches@...ts.linux.dev,
	stable@...r.kernel.org
Cc: Stefan Binding <sbinding@...nsource.cirrus.com>,
	Takashi Iwai <tiwai@...e.de>,
	Sasha Levin <sashal@...nel.org>,
	perex@...ex.cz,
	tiwai@...e.com,
	kailang@...ltek.com,
	gregkh@...uxfoundation.org,
	edson.drosdeck@...il.com,
	oder_chiou@...ltek.com,
	desikumar81@...il.com,
	alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH AUTOSEL 6.15 14/30] ALSA: hda/realtek: Add support for Acer Helios Laptops using CS35L41 HDA

From: Stefan Binding <sbinding@...nsource.cirrus.com>

[ Upstream commit d64cbb5ed9227566c068ac9300a85912234d10aa ]

Laptops use 2 CS35L41 Amps with HDA, using External boost with I2C.
Similar to previous Acer laptops, these laptops also need the
ALC255_FIXUP_PREDATOR_SUBWOOFER quirk to function properly.

Signed-off-by: Stefan Binding <sbinding@...nsource.cirrus.com>
Link: https://patch.msgid.link/20250515162848.405055-2-sbinding@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@...e.de>
Signed-off-by: Sasha Levin <sashal@...nel.org>
---

**YES** This commit should be backported to stable kernel trees. ##
Analysis ### What the commit does: This commit adds audio support for
Acer Helios laptops using CS35L41 HDA amplifiers. The specific changes
are: 1. **Adds new enum**: `ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2` 2.
**Adds new fixup entry**: Chains `cs35l41_fixup_i2c_two` with the
existing `ALC255_FIXUP_PREDATOR_SUBWOOFER` quirk 3. **Adds 3 PCI quirk
entries** for specific Acer models: - `0x1025, 0x1826, "Acer Helios
ZPC"` - `0x1025, 0x182c, "Acer Helios ZPD"` - `0x1025, 0x1844, "Acer
Helios ZPS"` ### Comparison with approved similar commits: This commit
follows **exactly the same pattern** as the four similar commits marked
"YES": - **Similar Commits #1-4**: All added PCI quirk entries for ASUS
laptops using CS35L41 HDA, with identical structure - **Same approach**:
Extending the quirk table to map new hardware IDs to existing, proven
fixup mechanisms - **Same scope**: Hardware-specific audio support using
well-established CS35L41 amplifier functionality ### Hardware support vs
bug fixing: This is **new hardware support** that enables audio
functionality on specific Acer Helios laptop models. The CS35L41
amplifier support and ALC255_FIXUP_PREDATOR_SUBWOOFER quirk already
exist - this simply extends support to new hardware variants. ### Risk
assessment: **Very low risk** because: 1. **Isolated impact**: Only
affects the three specific Acer Helios models listed (PCI IDs 0x1826,
0x182c, 0x1844) 2. **No architectural changes**: Pure quirk table
additions with no modifications to core audio logic 3. **Proven fixup
chain**: Both `cs35l41_fixup_i2c_two` and
`ALC255_FIXUP_PREDATOR_SUBWOOFER` are existing, stable fixups 4. **No
regression risk**: Doesn't modify behavior for any existing hardware ###
Stable kernel criteria alignment: ✅ **Fixes important bugs**: Enables
audio functionality that would otherwise be broken on these laptops ✅
**No new features**: Uses existing CS35L41 and Predator subwoofer
infrastructure ✅ **No architectural changes**: Only extends PCI quirk
tables ✅ **Minimal regression risk**: Changes are completely isolated to
specific hardware IDs ✅ **Subsystem-confined**: Limited to ALSA HDA
realtek driver quirks This commit perfectly matches the established
pattern of stable-worthy ALSA HDA hardware support commits and should be
backported to ensure audio functionality works properly for users with
these Acer Helios laptops.

 sound/pci/hda/patch_realtek.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 20ab1fb2195ff..cd0d7ba7320ef 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8029,6 +8029,7 @@ enum {
 	ALC283_FIXUP_DELL_HP_RESUME,
 	ALC294_FIXUP_ASUS_CS35L41_SPI_2,
 	ALC274_FIXUP_HP_AIO_BIND_DACS,
+	ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2,
 };

 /* A special fixup for Lenovo C940 and Yoga Duet 7;
@@ -9301,6 +9302,12 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ }
 		}
 	},
+	[ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2] = {
+		.type = HDA_FIXUP_FUNC,
+		.v.func = cs35l41_fixup_i2c_two,
+		.chained = true,
+		.chain_id = ALC255_FIXUP_PREDATOR_SUBWOOFER
+	},
 	[ALC256_FIXUP_MEDION_HEADSET_NO_PRESENCE] = {
 		.type = HDA_FIXUP_PINS,
 		.v.pins = (const struct hda_pintbl[]) {
@@ -10456,6 +10463,9 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1025, 0x1534, "Acer Predator PH315-54", ALC255_FIXUP_ACER_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1025, 0x159c, "Acer Nitro 5 AN515-58", ALC2XX_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x1025, 0x169a, "Acer Swift SFG16", ALC256_FIXUP_ACER_SFG16_MICMUTE_LED),
+	SND_PCI_QUIRK(0x1025, 0x1826, "Acer Helios ZPC", ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2),
+	SND_PCI_QUIRK(0x1025, 0x182c, "Acer Helios ZPD", ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2),
+	SND_PCI_QUIRK(0x1025, 0x1844, "Acer Helios ZPS", ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z),
 	SND_PCI_QUIRK(0x1028, 0x053c, "Dell Latitude E5430", ALC292_FIXUP_DELL_E7X),
 	SND_PCI_QUIRK(0x1028, 0x054b, "Dell XPS one 2710", ALC275_FIXUP_DELL_XPS),
-- 
2.39.5