linux-kernel - Re: [PATCH] MIPS: loongson2ef: cs5536: add missing function prototypes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aDmlolSlNS-JkdVq@alpha.franken.de>
Date: Fri, 30 May 2025 14:33:38 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Jiaxun Yang <jiaxun.yang@...goat.com>,
	linux-mips@...r.kernel.org
Subject: Re: [PATCH] MIPS: loongson2ef: cs5536: add missing function
 prototypes

On Wed, May 28, 2025 at 08:19:56PM -0700, Randy Dunlap wrote:
> Add missing function prototypes for cs5536, mostly for PCI functions,
> and for init_mfgpt_clocksource().
> 
> arch/mips/loongson2ef/common/cs5536/cs5536_ide.c:15:6: warning: no previous prototype for 'pci_ide_write_reg' [-Wmissing-prototypes]
>    15 | void pci_ide_write_reg(int reg, u32 value)
> arch/mips/loongson2ef/common/cs5536/cs5536_ide.c:96:5: warning: no previous prototype for 'pci_ide_read_reg' [-Wmissing-prototypes]
>    96 | u32 pci_ide_read_reg(int reg)
> 
> arch/mips/loongson2ef/common/cs5536/cs5536_ehci.c:15:6: warning: no previous prototype for 'pci_ehci_write_reg' [-Wmissing-prototypes]
>    15 | void pci_ehci_write_reg(int reg, u32 value)
> arch/mips/loongson2ef/common/cs5536/cs5536_ehci.c:75:5: warning: no previous prototype for 'pci_ehci_read_reg' [-Wmissing-prototypes]
>    75 | u32 pci_ehci_read_reg(int reg)
> 
> arch/mips/loongson2ef/common/cs5536/cs5536_acc.c:15:6: warning: no previous prototype for 'pci_acc_write_reg' [-Wmissing-prototypes]
>    15 | void pci_acc_write_reg(int reg, u32 value)
> arch/mips/loongson2ef/common/cs5536/cs5536_acc.c:62:5: warning: no previous prototype for 'pci_acc_read_reg' [-Wmissing-prototypes]
>    62 | u32 pci_acc_read_reg(int reg)
> 
> arch/mips/loongson2ef/common/cs5536/cs5536_ohci.c:15:6: warning: no previous prototype for 'pci_ohci_write_reg' [-Wmissing-prototypes]
>    15 | void pci_ohci_write_reg(int reg, u32 value)
> arch/mips/loongson2ef/common/cs5536/cs5536_ohci.c:70:5: warning: no previous prototype for 'pci_ohci_read_reg' [-Wmissing-prototypes]
>    70 | u32 pci_ohci_read_reg(int reg)
> 
> arch/mips/loongson2ef/common/cs5536/cs5536_isa.c:84:6: warning: no previous prototype for 'pci_isa_write_bar' [-Wmissing-prototypes]
>    84 | void pci_isa_write_bar(int n, u32 value)
> arch/mips/loongson2ef/common/cs5536/cs5536_isa.c:110:5: warning: no previous prototype for 'pci_isa_read_bar' [-Wmissing-prototypes]
>   110 | u32 pci_isa_read_bar(int n)
> arch/mips/loongson2ef/common/cs5536/cs5536_isa.c:134:6: warning: no previous prototype for 'pci_isa_write_reg' [-Wmissing-prototypes]
>   134 | void pci_isa_write_reg(int reg, u32 value)
> arch/mips/loongson2ef/common/cs5536/cs5536_isa.c:228:5: warning: no previous prototype for 'pci_isa_read_reg' [-Wmissing-prototypes]
>   228 | u32 pci_isa_read_reg(int reg)
> 
> arch/mips/loongson2ef/common/cs5536/cs5536_mfgpt.c:195:12: warning: no previous prototype for 'init_mfgpt_clocksource' [-Wmissing-prototypes]
>   195 | int __init init_mfgpt_clocksource(void)
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Jiaxun Yang <jiaxun.yang@...goat.com>
> Cc: linux-mips@...r.kernel.org
> Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> ---
>  arch/mips/include/asm/mach-loongson2ef/cs5536/cs5536_pci.h |   20 ++++++++++
>  1 file changed, 20 insertions(+)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]