linux-kernel - Re: [PATCH] kunit: configs: Enable CONFIG_INIT_STACK_ALL_PATTERN in all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1f131def-8ae4-42ab-8c4c-b3489515e6fd@opensource.cirrus.com>
Date: Fri, 30 May 2025 14:23:47 +0100
From: Richard Fitzgerald <rf@...nsource.cirrus.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: brendan.higgins@...ux.dev, davidgow@...gle.com, rmoar@...gle.com,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH] kunit: configs: Enable CONFIG_INIT_STACK_ALL_PATTERN in
 all_tests

On 29/5/25 16:38, Jakub Kicinski wrote:
> On Fri, 11 Apr 2025 10:59:04 +0100 Richard Fitzgerald wrote:
>> Enable CONFIG_INIT_STACK_ALL_PATTERN in all_tests.config. This helps
>> to detect use of uninitialized local variables.
>>
>> This option found an uninitialized data bug in the cs_dsp test.
>>
>> Signed-off-by: Richard Fitzgerald <rf@...nsource.cirrus.com>
>> ---
>>   tools/testing/kunit/configs/all_tests.config | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/kunit/configs/all_tests.config b/tools/testing/kunit/configs/all_tests.config
>> index cdd9782f9646..4a60bb71fe72 100644
>> --- a/tools/testing/kunit/configs/all_tests.config
>> +++ b/tools/testing/kunit/configs/all_tests.config
>> @@ -10,6 +10,7 @@ CONFIG_KUNIT_EXAMPLE_TEST=y
>>   CONFIG_KUNIT_ALL_TESTS=y
>>   
>>   CONFIG_FORTIFY_SOURCE=y
>> +CONFIG_INIT_STACK_ALL_PATTERN=y
> 
> This breaks kunit for older compilers:

Drop it then.
It's not essential. Just something that showed a bug in a test so I
thought would be useful to test always. But if there are compatibility
problems it would be better not to have it in all_tests.