linux-kernel - Re: [PATCH 1/1] dt-bindings: soc: add vf610 reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250530-construct-library-64ec665a6fea@spud>
Date: Fri, 30 May 2025 16:23:31 +0100
From: Conor Dooley <conor@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: Christophe Leroy <christophe.leroy@...roup.eu>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"open list:FREESCALE SOC DRIVERS" <linuxppc-dev@...ts.ozlabs.org>,
	"moderated list:FREESCALE SOC DRIVERS" <linux-arm-kernel@...ts.infradead.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: soc: add vf610 reset controller

On Wed, May 28, 2025 at 11:43:59AM -0400, Frank Li wrote:
> On Mon, May 26, 2025 at 04:54:30PM +0100, Conor Dooley wrote:
> > On Thu, May 22, 2025 at 05:39:50PM -0400, Frank Li wrote:
> > > Add vf610 reset controller, which used to reboot system to fix below
> > > CHECK_DTB warnings:
> > >
> > > arch/arm/boot/dts/nxp/vf/vf610-bk4.dtb: /soc/bus@...00000/src@...6e000:
> > >     failed to match any schema with compatible: ['fsl,vf610-src', 'syscon']
> > >
> > > Signed-off-by: Frank Li <Frank.Li@....com>
> > > ---
> > >  .../bindings/soc/fsl/fsl,vf610-src.yaml       | 46 +++++++++++++++++++
> > >  1 file changed, 46 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/soc/fsl/fsl,vf610-src.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/soc/fsl/fsl,vf610-src.yaml b/Documentation/devicetree/bindings/soc/fsl/fsl,vf610-src.yaml
> > > new file mode 100644
> > > index 0000000000000..4c92a5e4892bf
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/soc/fsl/fsl,vf610-src.yaml
> > > @@ -0,0 +1,46 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas//soc/fsl/fsl,vf610-src.yaml#
> >
> > It's a reset controller then, shouldn't it be in /reset, not //soc?
> 
> It is not reset controller since there are not #reset-cells property to
> reset other models. It just provides syscon to reboot the whole system.

| Add vf610 reset controller
| The System Reset Controller (SRC) generates the resets for the device.

Giving me mixed signal here chief. If you call something a reset
controller multiple times without any additional clarification that it
does not provide resets to peripherals, how is anyone reading the patch
not supposed to come to the same conclusion as me?

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)