linux-kernel - Re: [PATCHv2 perf/core 00/22] uprobes: Add support to optimize usdt probes on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250530153516.GA25160@redhat.com>
Date: Fri, 30 May 2025 17:35:16 +0200
From: Oleg Nesterov <oleg@...hat.com>
To: Jiri Olsa <jolsa@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>,
	Andrii Nakryiko <andrii@...nel.org>,
	Alejandro Colomar <alx@...nel.org>,
	Eyal Birger <eyal.birger@...il.com>, kees@...nel.org,
	bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-trace-kernel@...r.kernel.org, x86@...nel.org,
	Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
	John Fastabend <john.fastabend@...il.com>,
	Hao Luo <haoluo@...gle.com>, Steven Rostedt <rostedt@...dmis.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Alan Maguire <alan.maguire@...cle.com>,
	David Laight <David.Laight@...LAB.COM>,
	Thomas Weißschuh <thomas@...ch.de>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCHv2 perf/core 00/22] uprobes: Add support to optimize usdt
 probes on x86_64

On 05/15, Jiri Olsa wrote:
>
> Changes from v1:
> - rebased on top of tip/master + mm/mm-stable + 1 extra change [1]
> - keep the refcrf offset update inside write_insn and enabling it
>   via function argument
> - fixed locking comment for uprobe_write_opcode, but skiped suggested
>   comment on register_for_each_vma, need more thinking on that [Oleg]
> - added acks
> - removed refctr from uprobe_trampoline object [Oleg]
> - change find_nearest_page to use vm_unmapped_area [Oleg]
> - re-structured x86 set_swbp [Andrii]
> - use -EINVAL in __arch_uprobe_optimize [Andrii]
> - added usdt.h from libbpf/usdt project [Andrii]
> - several minor test code changes [Andrii]
> - man page updates [Alejandro]

I forgot to send this email a week ago, sorry...

This version seems to address my concerns. I don't see anything obviously
wrong. So if this optimization is important for users... FWIW,

For 1/22 - 10/22

Acked-by: Oleg Nesterov <oleg@...hat.com>