| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ead6711d-8e38-43b7-bc50-bcc3f7cddb70@kernel.org> Date: Sat, 31 May 2025 15:39:55 +0200 From: Krzysztof Kozlowski <krzk@...nel.org> To: Geert Uytterhoeven <geert@...ux-m68k.org> Cc: shao.mingyin@....com.cn, ulf.hansson@...aro.org, magnus.damm@...il.com, linux-pm@...r.kernel.org, linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org, yang.yang29@....com.cn, xu.xin16@....com.cn, yang.tao172@....com.cn, ye.xingchen@....com.cn Subject: Re: pmdomain: renesas: rcar: Use str_on_off() helper in rcar_sysc_power() and rcar_gen4_sysc_power() On 30/05/2025 10:07, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Thu, 29 May 2025 at 08:41, Krzysztof Kozlowski <krzk@...nel.org> wrote: >> On 29/05/2025 04:13, shao.mingyin@....com.cn wrote: >>> From: Shao Mingyin <shao.mingyin@....com.cn> >>> >>> Remove hard-coded strings by using the str_on_off() helper function. >>> >>> Signed-off-by: Shao Mingyin <shao.mingyin@....com.cn> >>> --- >>> drivers/pmdomain/renesas/rcar-gen4-sysc.c | 3 ++- >>> drivers/pmdomain/renesas/rcar-sysc.c | 3 ++- >> >> Stop sending such trivial patches one driver per patch, but entire >> subsystem in one patch. That's a lot of churn, considering this was >> rejected: > > Was it? I only see my Rb, and a review comment asking for more... > >> https://lore.kernel.org/all/20250114203547.1013010-1-krzysztof.kozlowski@linaro.org/ Indeed this one was not, but my other patchsets were - several subsystems clearly expressed that this is just a churn. So if doing this, because you do not consider it a churn, do it all at once to, not line by line. Best regards, Krzysztof
Powered by blists - more mailing lists