linux-kernel - Re: [PATCH v2 1/2] iio: bmi270: suspend and resume triggering on relevant pm operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250531175913.251d64d3@jic23-huawei>
Date: Sat, 31 May 2025 17:59:13 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Denis Benato <benato.denis96@...il.com>
Cc: David Lechner <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, Alex Lanzano <lanzano.alex@...il.com>, Andy
 Shevchenko <andy@...nel.org>, Uwe Kleine-König
 <u.kleine-koenig@...gutronix.de>, Peter Zijlstra <peterz@...radead.org>,
 Danila Tikhonov <danila@...xyga.com>, Greg KH <gregkh@...uxfoundation.org>,
 "Derek J . Clark" <derekjohn.clark@...il.com>, Philip Müller <philm@...jaro.org>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, Justin Weiss <justin@...tinweiss.com>
Subject: Re: [PATCH v2 1/2] iio: bmi270: suspend and resume triggering on
 relevant pm operations

On Sun, 25 May 2025 16:25:29 +0200
Denis Benato <benato.denis96@...il.com> wrote:

> Prevent triggers from stop working after the device has entered sleep:
> use iio_device_suspend_triggering and iio_device_resume_triggering helpers.
> 
> Closes: https://lore.kernel.org/all/31d7f7aa-e834-4fd0-a66a-e0ff528425dc@gmail.com

This is a tag, so no blank line here.

I've fixed this in both patches and applied them to the to testing branch of iio.
Currently I'm not planning to rush these in but I could treat them as fixes if
general view is that I should.

> 
> Signed-off-by: Denis Benato <benato.denis96@...il.com>
> Tested-by: Justin Weiss <justin@...tinweiss.com>
> ---
>  drivers/iio/imu/bmi270/bmi270.h      |  2 ++
>  drivers/iio/imu/bmi270/bmi270_core.c | 20 ++++++++++++++++++++
>  drivers/iio/imu/bmi270/bmi270_i2c.c  |  2 ++
>  drivers/iio/imu/bmi270/bmi270_spi.c  |  2 ++
>  4 files changed, 26 insertions(+)
> 
> diff --git a/drivers/iio/imu/bmi270/bmi270.h b/drivers/iio/imu/bmi270/bmi270.h
> index d94525f6aee8..a6c4204032fc 100644
> --- a/drivers/iio/imu/bmi270/bmi270.h
> +++ b/drivers/iio/imu/bmi270/bmi270.h
> @@ -20,4 +20,6 @@ struct device;
>  int bmi270_core_probe(struct device *dev, struct regmap *regmap,
>  		      const struct bmi270_chip_info *chip_info);
>  
> +extern const struct dev_pm_ops bmi270_core_pm_ops;
> +
>  #endif  /* BMI270_H_ */
> diff --git a/drivers/iio/imu/bmi270/bmi270_core.c b/drivers/iio/imu/bmi270/bmi270_core.c
> index 2e4469f30d53..b54658f972ad 100644
> --- a/drivers/iio/imu/bmi270/bmi270_core.c
> +++ b/drivers/iio/imu/bmi270/bmi270_core.c
> @@ -982,6 +982,7 @@ int bmi270_core_probe(struct device *dev, struct regmap *regmap,
>  	indio_dev->available_scan_masks = bmi270_avail_scan_masks;
>  	indio_dev->modes = INDIO_DIRECT_MODE;
>  	indio_dev->info = &bmi270_info;
> +	dev_set_drvdata(data->dev, indio_dev);
>  
>  	ret = bmi270_trigger_probe(data, indio_dev);
>  	if (ret)
> @@ -997,6 +998,25 @@ int bmi270_core_probe(struct device *dev, struct regmap *regmap,
>  }
>  EXPORT_SYMBOL_NS_GPL(bmi270_core_probe, "IIO_BMI270");
>  
> +static int bmi270_core_runtime_suspend(struct device *dev)
> +{
> +	struct iio_dev *indio_dev = dev_get_drvdata(dev);
> +
> +	return iio_device_suspend_triggering(indio_dev);
> +}
> +
> +static int bmi270_core_runtime_resume(struct device *dev)
> +{
> +	struct iio_dev *indio_dev = dev_get_drvdata(dev);
> +
> +	return iio_device_resume_triggering(indio_dev);
> +}
> +
> +const struct dev_pm_ops bmi270_core_pm_ops = {
> +	RUNTIME_PM_OPS(bmi270_core_runtime_suspend, bmi270_core_runtime_resume, NULL)
> +};
> +EXPORT_SYMBOL_NS_GPL(bmi270_core_pm_ops, "IIO_BMI270");
> +
>  MODULE_AUTHOR("Alex Lanzano");
>  MODULE_DESCRIPTION("BMI270 driver");
>  MODULE_LICENSE("GPL");
> diff --git a/drivers/iio/imu/bmi270/bmi270_i2c.c b/drivers/iio/imu/bmi270/bmi270_i2c.c
> index 44699ab58909..c77839b03a96 100644
> --- a/drivers/iio/imu/bmi270/bmi270_i2c.c
> +++ b/drivers/iio/imu/bmi270/bmi270_i2c.c
> @@ -4,6 +4,7 @@
>  #include <linux/iio/iio.h>
>  #include <linux/module.h>
>  #include <linux/mod_devicetable.h>
> +#include <linux/pm.h>
>  #include <linux/regmap.h>
>  
>  #include "bmi270.h"
> @@ -52,6 +53,7 @@ static const struct of_device_id bmi270_of_match[] = {
>  static struct i2c_driver bmi270_i2c_driver = {
>  	.driver = {
>  		.name = "bmi270_i2c",
> +		.pm = pm_ptr(&bmi270_core_pm_ops),
>  		.acpi_match_table = bmi270_acpi_match,
>  		.of_match_table = bmi270_of_match,
>  	},
> diff --git a/drivers/iio/imu/bmi270/bmi270_spi.c b/drivers/iio/imu/bmi270/bmi270_spi.c
> index 88a77aba5e4f..19dd7734f9d0 100644
> --- a/drivers/iio/imu/bmi270/bmi270_spi.c
> +++ b/drivers/iio/imu/bmi270/bmi270_spi.c
> @@ -3,6 +3,7 @@
>  #include <linux/iio/iio.h>
>  #include <linux/mod_devicetable.h>
>  #include <linux/module.h>
> +#include <linux/pm.h>
>  #include <linux/regmap.h>
>  #include <linux/spi/spi.h>
>  
> @@ -79,6 +80,7 @@ static const struct of_device_id bmi270_of_match[] = {
>  static struct spi_driver bmi270_spi_driver = {
>  	.driver = {
>  		.name = "bmi270",
> +		.pm = pm_ptr(&bmi270_core_pm_ops),
>  		.of_match_table = bmi270_of_match,
>  	},
>  	.probe = bmi270_spi_probe,