linux-kernel - Re: [PATCH v2] x86/mm: resize user_pcid_flush_mask for PTI / broadcast TLB flush combination

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aDqu5Fhbf3mV6Xsj@gmail.com>
Date: Sat, 31 May 2025 09:25:24 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Rik van Riel <riel@...riel.com>
Cc: Dave Hansen <dave.hansen@...ux.intel.com>,
	Andy Lutomirski <luto@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Borislav Petkov <bp@...en8.de>, x86@...nel.org,
	linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH v2] x86/mm: resize user_pcid_flush_mask for PTI /
 broadcast TLB flush combination


* Rik van Riel <riel@...riel.com> wrote:

> [re-sent]
> ---8<---
> From 96958fa1ed02e2434305fc7b0e37374eee899daf Mon Sep 17 00:00:00 2001
> From: Rik van Riel <riel@...a.com>
> Date: Fri, 16 May 2025 08:37:04 -0700
> Subject: [PATCH] x86/mm: resize user_pcid_flush_mask for PTI / broadcast TLB flush combination

1)

Please always check whether the title style you are using matches that 
of the subsystem you are submitting it to. (x86 in this case, and no, 
it doesn't match it)

2)

Also, 'resize' is not the proper verb for a bug fix ...

> - invalidate_user_asid() sets a bit corresponding to the process pcid in user_pcid_flush_mask
> - SWITCH_TO_USER_CR3 tests and clears a bit corresponding to the process PCID in user_pcid_flush_mask

3)

Why are 'pcid' and 'PCID' capitalized differently right next to each 
other? This is completely unnecessary noise that makes a maintainer 
question of how attentively this patch was created.

Thanks,

	Ingo