linux-kernel - Re: [PATCH] rust: doc: Clean up formatting in io.rs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DAA6AJ0N7JAA.WCEOCHKVFLDD@kernel.org>
Date: Sat, 31 May 2025 09:38:05 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: "Sai Vishnu" <saivishnu725@...il.com>, "Miguel Ojeda"
 <miguel.ojeda.sandonis@...il.com>
Cc: <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <ojeda@...nel.org>, <alex.gaynor@...il.com>, <boqun.feng@...il.com>,
 <gary@...yguo.net>, <bjorn3_gh@...tonmail.com>, <a.hindborg@...nel.org>,
 <aliceryhl@...gle.com>, <tmgross@...ch.edu>, <dakr@...nel.org>,
 <gregkh@...uxfoundation.org>, <daniel.almeida@...labora.com>,
 <me@...enk.dev>
Subject: Re: [PATCH] rust: doc: Clean up formatting in io.rs

On Sat May 31, 2025 at 4:57 AM CEST, Sai Vishnu wrote:
> On Sat, May 31, 2025 at 1:09 AM Miguel Ojeda
> <miguel.ojeda.sandonis@...il.com> wrote:
>>
>> We should also probably add "region" there, after "memory", or
>> similar, especially if we remove the second part.
>
> Thanks for the feedback! I’ve decided to update the comment to just:
>
> /// IO-mapped memory
>
> I’m new to kernel development. Should I just share the updated patch
> here or send a v2 that refers to this one? Thanks!

Normally, you send a v2 with a changelog and a link to each previous
version. For patch series with a cover letter it is often placed there.
Since you don't need one, you should put the changelog after the `---`
(anything that isn't a diff there will be ignored by git when applying).

I'd give others a few more days to review. (this patch there most likely
won't be any additional comments, but it also doesn't hurt)

---
Cheers,
Benno