[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5ffadce9-7121-465d-ad41-81cf9f626019@quicinc.com>
Date: Sun, 1 Jun 2025 18:28:56 +0530
From: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
Bjorn Andersson
<andersson@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Rob Herring
<robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley
<conor+dt@...nel.org>,
Srinivas Kandagatla <srini@...nel.org>,
Liam Girdwood
<lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Konrad Dybcio
<konradybcio@...nel.org>
CC: <cros-qcom-dts-watchers@...omium.org>, <linux-arm-msm@...r.kernel.org>,
<linux-gpio@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-sound@...r.kernel.org>,
<kernel@....qualcomm.com>, Mohammad Rafi Shaik <quic_mohs@...cinc.com>
Subject: Re: [PATCH v4 7/8] arm64: dts: qcom: qcm6490-idp: Add WSA8830
speakers and WCD9370 headset codec
On 5/31/2025 6:05 PM, Konrad Dybcio wrote:
> On 5/27/25 1:12 PM, Prasad Kumpatla wrote:
>> From: Mohammad Rafi Shaik <quic_mohs@...cinc.com>
>>
>> Add nodes for WSA8830 speakers and WCD9370 headset codec
>> on qcm6490-idp board.
>>
>> Enable lpass macros along with audio support pin controls.
>>
>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@...cinc.com>
>> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
>> ---
>
> [...]
>
>> &uart5 {
>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
>> index 542a39ca72bb..2e75e7706fb4 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
>> @@ -29,6 +29,30 @@ &lpass_dmic23_data {
>> bias-pull-down;
>> };
>>
>> +&lpass_rx_swr_clk {
>> + drive-strength = <2>;
>> + slew-rate = <1>;
>> + bias-disable;
>> +};
>> +
>> +&lpass_rx_swr_data {
>> + drive-strength = <2>;
>> + slew-rate = <1>;
>> + bias-bus-hold;
>> +};
>> +
>> +&lpass_tx_swr_clk {
>> + drive-strength = <2>;
>> + slew-rate = <1>;
>> + bias-disable;
>> +};
>> +
>> +&lpass_tx_swr_data {
>> + drive-strength = <2>;
>> + slew-rate = <1>;
>> + bias-bus-hold;
>> +};
>
> All other DTs that overwrite these pins seem to be setting the
> exact same settings.. And given this pin is connected to an on-SoC
> peripheral, I think it would make sense to consolidate these in
> sc7280.dtsi
Ack
Thanks,
Prasad
>
> Konrad
Powered by blists - more mailing lists