linux-kernel - Re: [PATCH batadv 4/5] batman-adv: remove global hardif list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2767731.Lt9SDvczpP@sven-l14>
Date: Sun, 01 Jun 2025 15:36:44 +0200
From: Sven Eckelmann <sven@...fation.org>
To: Marek Lindner <marek.lindner@...lbox.org>,
 Simon Wunderlich <sw@...onwunderlich.de>,
 Antonio Quartulli <antonio@...delbit.com>,
 Matthias Schiffer <mschiffer@...verse-factory.net>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 b.a.t.m.a.n@...ts.open-mesh.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH batadv 4/5] batman-adv: remove global hardif list

On Sunday, 1 June 2025 15:10:50 CEST Sven Eckelmann wrote:
> So, even getting the parent (see `ASSERT_RTNL` in 
> `netdev_master_upper_dev_get`) of the lower interface is a no-go at that 
> point.

I didn't want to say here that this specific operation is necessary here. Just 
wanted to point out that operating on these data structures might not always 
be possible at that point. This is why I tried to point out that it might be 
better to have something "good enough" using RCU which is managed outside this 
context (write-only protected using rtnl_lock).

The idea of having something specific to meshif that still manages to detect 
(beforehand) if there's a path to `batadv_interface_tx` - while `skb_iif` 
remains set to a specific interface along the way - sounds like an 
implementation nightmare to me.

Kind regards,
	Sven
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)