linux-kernel - Re: [PATCH v2] rust: doc: Clean up formatting in io.rs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72n_pN9i_bnhuE5eD8jE-G9FwP566tfL8w+v44pHBWBu2Q@mail.gmail.com>
Date: Sun, 1 Jun 2025 22:00:23 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: saivishnu725@...il.com
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	ojeda@...nel.org, alex.gaynor@...il.com, boqun.feng@...il.com, 
	gary@...yguo.net, bjorn3_gh@...tonmail.com, lossin@...nel.org, 
	a.hindborg@...nel.org, aliceryhl@...gle.com, tmgross@...ch.edu, 
	dakr@...nel.org, gregkh@...uxfoundation.org, daniel.almeida@...labora.com, 
	me@...enk.dev
Subject: Re: [PATCH v2] rust: doc: Clean up formatting in io.rs

On Sun, Jun 1, 2025 at 6:52 PM <saivishnu725@...il.com> wrote:
>
> From: Sai Vishnu M <saivishnu725@...il.com>

This "From" line is fine, but it is best to avoid it by configuring
your setup in a way that the From email header matches your Git
author. In other words, the email author is now just
"<saivishnu725@...il.com>", without your name.

>

The commit message is empty -- the kernel requires providing an
explanation which typically includes the "what" and the "why". In
trivial patches like this one it may seem pointless, but still, it is
good to explain the change :)

> -/// IO-mapped memory, starting at the base address `addr` and spanning `maxlen` bytes.

This appears to be the line from v1 -- the patch should apply against
the tree, not against the previous version of the patch. In other
words, patch versions are like rebased, rather than stacked.

> +/// IO-mapped memory region.

The change itself looks good to me, thanks!

> v1: Edit the doc comment for `IoMem` to remove the usage of
> `@` for parameters and replace them with backticks.
> Link to v1: https://lkml.org/lkml/2025/5/30/550

Please prefer lore.kernel.org for links.

> v2: Removed reference to internal variables altogether.
>
> Thanks!
>
> 2.49.0

The changelog (and any other comments) normally goes after the `---`
line (before the diffstat), rather than at the bottom.

By the way, since we will need a v3 to fix these bits, could you
please try the `--base` flag? It is always nice to know against which
commit a patch is generated, even if in cases like this is obvious,
and helps other tooling (e.g. testing bots).

Thanks for the patch!

Cheers,
Miguel