linux-kernel - [PATCH AUTOSEL 6.15 088/110] ALSA: hda/realtek: Add support for Acer Helios Laptops using CS35L41 HDA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250601232435.3507697-88-sashal@kernel.org>
Date: Sun,  1 Jun 2025 19:24:10 -0400
From: Sasha Levin <sashal@...nel.org>
To: patches@...ts.linux.dev,
	stable@...r.kernel.org
Cc: Stefan Binding <sbinding@...nsource.cirrus.com>,
	Takashi Iwai <tiwai@...e.de>,
	Sasha Levin <sashal@...nel.org>,
	perex@...ex.cz,
	tiwai@...e.com,
	kailang@...ltek.com,
	simont@...nsource.cirrus.com,
	josh@...huagrisham.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH AUTOSEL 6.15 088/110] ALSA: hda/realtek: Add support for Acer Helios Laptops using CS35L41 HDA

From: Stefan Binding <sbinding@...nsource.cirrus.com>

[ Upstream commit d64cbb5ed9227566c068ac9300a85912234d10aa ]

Laptops use 2 CS35L41 Amps with HDA, using External boost with I2C.
Similar to previous Acer laptops, these laptops also need the
ALC255_FIXUP_PREDATOR_SUBWOOFER quirk to function properly.

Signed-off-by: Stefan Binding <sbinding@...nsource.cirrus.com>
Link: https://patch.msgid.link/20250515162848.405055-2-sbinding@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@...e.de>
Signed-off-by: Sasha Levin <sashal@...nel.org>
---

Based on my analysis of the commit and comparing it to similar commits
that were marked with "Backport Status: YES", I can now provide my
assessment: **YES** This commit should be backported to stable kernel
trees. **Detailed Analysis:** **Code Changes Analysis:** 1. **Enum
Addition**: The commit adds `ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2` to
the enum list at line 8029, which is a standard pattern for adding new
HDA fixups. 2. **Fixup Implementation**: Lines 9303-9307 add the actual
fixup implementation: ```c [ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2] = {
.type = HDA_FIXUP_FUNC, .v.func = cs35l41_fixup_i2c_two, .chained =
true, .chain_id = ALC255_FIXUP_PREDATOR_SUBWOOFER }; ``` This follows
the exact same pattern as existing CS35L41 fixups in the codebase. 3.
**Device Quirks**: Lines 10444-10446 add three new Acer Helios laptop
models: ```c SND_PCI_QUIRK(0x1025, 0x1826, "Acer Helios ZPC",
ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2), SND_PCI_QUIRK(0x1025, 0x182c,
"Acer Helios ZPD", ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2),
SND_PCI_QUIRK(0x1025, 0x1844, "Acer Helios ZPS",
ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2), ``` **Comparison to Similar
Commits:** This commit is nearly identical in structure and purpose to
Similar Commits #1-4, which were all marked with "Backport Status: YES".
Like those commits: - It adds hardware support for specific laptop
models - Uses existing CS35L41 infrastructure (`cs35l41_fixup_i2c_two`
function) - Chains to existing predator subwoofer fixup
(`ALC255_FIXUP_PREDATOR_SUBWOOFER`) - Makes minimal, contained changes -
Follows established patterns for HDA audio fixups **Backport
Suitability:** 1. **Important Bug Fix**: This enables audio
functionality on specific Acer Helios laptop models that would otherwise
have non-functional speakers 2. **Small and Contained**: The changes are
minimal and isolated to the realtek patch file 3. **Low Risk**: Uses
existing, well-tested CS35L41 and predator subwoofer code paths 4. **No
Architectural Changes**: Simply adds new device IDs and combines
existing fixups 5. **Hardware Enablement**: Essential for users with
these specific laptop models The commit message indicates this adds
support for CS35L41 amplifiers with I2C interface and external boost,
which is critical for proper audio functionality on these laptops.
Without this fix, users would have non-functional speakers on these
specific Acer Helios models. This follows the stable tree criteria
perfectly: it's an important hardware enablement fix with minimal risk
of regression.

 sound/pci/hda/patch_realtek.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 20ab1fb2195ff..cd0d7ba7320ef 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8029,6 +8029,7 @@ enum {
 	ALC283_FIXUP_DELL_HP_RESUME,
 	ALC294_FIXUP_ASUS_CS35L41_SPI_2,
 	ALC274_FIXUP_HP_AIO_BIND_DACS,
+	ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2,
 };

 /* A special fixup for Lenovo C940 and Yoga Duet 7;
@@ -9301,6 +9302,12 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ }
 		}
 	},
+	[ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2] = {
+		.type = HDA_FIXUP_FUNC,
+		.v.func = cs35l41_fixup_i2c_two,
+		.chained = true,
+		.chain_id = ALC255_FIXUP_PREDATOR_SUBWOOFER
+	},
 	[ALC256_FIXUP_MEDION_HEADSET_NO_PRESENCE] = {
 		.type = HDA_FIXUP_PINS,
 		.v.pins = (const struct hda_pintbl[]) {
@@ -10456,6 +10463,9 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1025, 0x1534, "Acer Predator PH315-54", ALC255_FIXUP_ACER_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1025, 0x159c, "Acer Nitro 5 AN515-58", ALC2XX_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x1025, 0x169a, "Acer Swift SFG16", ALC256_FIXUP_ACER_SFG16_MICMUTE_LED),
+	SND_PCI_QUIRK(0x1025, 0x1826, "Acer Helios ZPC", ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2),
+	SND_PCI_QUIRK(0x1025, 0x182c, "Acer Helios ZPD", ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2),
+	SND_PCI_QUIRK(0x1025, 0x1844, "Acer Helios ZPS", ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z),
 	SND_PCI_QUIRK(0x1028, 0x053c, "Dell Latitude E5430", ALC292_FIXUP_DELL_E7X),
 	SND_PCI_QUIRK(0x1028, 0x054b, "Dell XPS one 2710", ALC275_FIXUP_DELL_XPS),
-- 
2.39.5