linux-kernel - Re: [PATCH] LoongArch: Add numa_add_reserved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <280ed3f89c2ca4c97059ef642a092cbcf7cda869.camel@xry111.site>
Date: Sun, 01 Jun 2025 19:07:41 +0800
From: Xi Ruoyao <xry111@...111.site>
To: Yulong Han <wheatfox17@...oud.com>, chenhuacai@...nel.org
Cc: kernel@...0n.name, broonie@...nel.org, loongarch@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] LoongArch: Add numa_add_reserved_memblk() support in
 numa

On Sun, 2025-06-01 at 18:29 +0800, Yulong Han wrote:
> This patch fixes the error below when compiling kernel with
> loongarch's loongson3_defconfig:
> 
> drivers/acpi/numa/srat.c: In function ‘acpi_parse_cfmws’:
> drivers/acpi/numa/srat.c:467:13: error: implicit declaration of function
> ‘numa_add_reserved_memblk’ [-Werror=implicit-function-declaration]
>   467 |         if (numa_add_reserved_memblk(node, start, end) < 0) {

> 
> The error is caused by the missing the newly added 
> numa_add_reserved_memblk (under include/linux/numa_memblks.h) definition
> inside loongarch's numa related code.
> 
> The commit's code(style) was formatted by ./scripts/checkpatch.pl

> Signed-off-by: Yulong Han <wheatfox17@...oud.com>

Note that numa_add_reserved_memblk would be declared by 
linux/numa_memblks.h if CONFIG_NUMA_MEMBLKS, and CONFIG_NUMA_MEMBLKS
would be select after
https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-next&id=a24f2fb70cb62180486ad4d74f809ff35ddd1cf9
which would be merged into Torvalds' tree soon.  You change fails to
notice this and it's just covering up the issue.

Thus

Nacked-by: Xi Ruoyao <xry111@...111.site>

-- 
Xi Ruoyao <xry111@...111.site>
School of Aerospace Science and Technology, Xidian University