linux-kernel - Re: [PATCH] scsi: iscsi: fix incorrect error path labels for flashnode operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08566ecc-e056-4331-828c-77f3fa22c3b5@oracle.com>
Date: Mon, 2 Jun 2025 11:19:15 -0500
From: Mike Christie <michael.christie@...cle.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>, lduncan@...e.com,
        cleech@...hat.com, James.Bottomley@...senPartnership.com,
        martin.petersen@...cle.com, open-iscsi@...glegroups.com,
        linux-scsi@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, darren.kenny@...cle.com
Subject: Re: [PATCH] scsi: iscsi: fix incorrect error path labels for
 flashnode operations

On 5/30/25 2:29 PM, Alok Tiwari wrote:
> Correct the error handling goto labels used when host lookup fails in
> various flashnode-related event handlers:
> - iscsi_new_flashnode()
> - iscsi_del_flashnode()
> - iscsi_login_flashnode()
> - iscsi_logout_flashnode()
> - iscsi_logout_flashnode_sid()
> 
> scsi_host_put() is not required when shost is NULL, so jumping to the
> correct label avoids unnecessary operations. These functions previously
> jumped to the wrong goto label (put_host), which did not match the
> intended cleanup logic.
> Updated to use the correct exit labels (exit_new_fnode, exit_del_fnode,
> etc.) to ensure proper error handling.
> Also removed the unused put_host label under iscsi_new_flashnode()
> as it is no longer needed.
> 
> No functional changes beyond accurate error path correction.
> 
> Fixes: c6a4bb2ef596 ("[SCSI] scsi_transport_iscsi: Add flash node mgmt support")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>


Thanks.

Reviewed-by: Mike Christie <michael.christie@...cle.com>