linux-kernel - Re: [PATCH v3 0/3] pwm: axi-pwmgen: add external clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m6evwezyzewtbiacqxfh4x6klrnc4425j6vayg7gtbytuodqpm@r72ajswzfo4k>
Date: Mon, 2 Jun 2025 18:39:40 +0200
From: Uwe Kleine-König <ukleinek@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Michael Hennerich <michael.hennerich@...log.com>, 
	Nuno Sá <nuno.sa@...log.com>, Trevor Gamblin <tgamblin@...libre.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, linux-pwm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v3 0/3] pwm: axi-pwmgen: add external clock

Hello David,

On Thu, May 29, 2025 at 11:53:17AM -0500, David Lechner wrote:
> When we created the driver for the AXI PWMGEN IP block, we overlooked
> the fact that it can optionally be configured to use an external clock
> in addition to the AXI bus clock. This is easy to miss in testing
> because the bus clock is always on because it is driving other
> peripherals as well.
> 
> Up to now, users were specifying the external clock if there was one and
> the AXI bus clock otherwise. But the proper way to do this is to would
> be to always specify the bus clock and only specify the external clock
> if the IP block has been configured to use it.
> 
> To fix this, we add clock-names to the devicetree bindings and change
> clocks to allow 1 or 2 clocks.

I applied path #1 for 6.17-rc1 and will send patches #2 and #3 to Linus
before 6.16.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)