linux-kernel - Re: [PATCH 2/2] clk: tests: add clk_hw_get_dev() and clk_hw_get_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aD3aFs-hbtYw0PVO@x1>
Date: Mon, 2 Jun 2025 13:06:30 -0400
From: Brian Masney <bmasney@...hat.com>
To: Jerome Brunet <jbrunet@...libre.com>
Cc: Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, linux-clk@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] clk: tests: add clk_hw_get_dev() and
 clk_hw_get_of_node() tests

On Thu, Apr 17, 2025 at 03:44:23PM +0200, Jerome Brunet wrote:
> Add kunit test suites clk_hw_get_dev() and clk_hw_get_of_node()
> for clocks registered with clk_hw_register() and of_clk_hw_register()
> 
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>

Reviewed-by: Brian Masney <bmasney@...hat.com>

I also ran the tests with no issues.

Just a few minor nits below if you happen to spin a v2.

> @@ -3016,7 +3023,7 @@ KUNIT_ARRAY_PARAM(clk_register_clk_parent_data_device_hw_test,
>   */
>  static void clk_register_clk_parent_data_device_hw_test(struct kunit *test)
>  {
> -	struct clk_register_clk_parent_data_device_ctx *ctx;
> +	struct clk_register_device_ctx *ctx;
>  	const struct clk_register_clk_parent_data_test_case *test_param;
>  	struct clk_dummy_context *parent;
>  	struct clk_hw *parent_hw;

Put in reverse Christmas tree where possible.

> +static void clk_hw_register_get_of_node_test(struct kunit *test)
> +{
> +	const struct clk_hw_get_dev_of_node_test_param *test_param = test->param_value;
> +	struct clk_register_device_ctx *ctx = test->priv;
> +	struct device *dev = test_param->has_ref ? ctx->dev : NULL;
> +	struct device_node *np = NULL;
> +
> +	if (dev) {
> +		np = dev_of_node(dev);
> +
> +		if (!np)
> +			np = dev_of_node(dev->parent);

Remove newline before the if().

Brian