linux-kernel - Re: [RFC PATCH 02/10] net: dsa: b53: prevent FAST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03565c9a-9345-4c1e-9c00-b16ed8acbcf5@broadcom.com>
Date: Mon, 2 Jun 2025 11:01:40 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Vladimir Oltean <olteanv@...il.com>,
 Álvaro Fernández Rojas <noltari@...il.com>
Cc: jonas.gorski@...il.com, andrew@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 vivien.didelot@...il.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, dgcbueu@...il.com
Subject: Re: [RFC PATCH 02/10] net: dsa: b53: prevent FAST_AGE access on
 BCM5325

On 6/2/25 02:37, Vladimir Oltean wrote:
> Hello,
> 
> On Sat, May 31, 2025 at 12:13:00PM +0200, Álvaro Fernández Rojas wrote:
>> BCM5325 doesn't implement FAST_AGE registers so we should avoid reading or
>> writing them.
>>
>> Fixes: 967dd82ffc52 ("net: dsa: b53: Add support for Broadcom RoboSwitch")
>> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
>> ---
> 
> How about implementing a "slow age" procedure instead? Walk through the
> FDB, and delete the dynamically learned entries for the port?
> 
> Address aging is important for STP state transitions.

That's a good suggestion, I suppose for now this can be b53 specific 
until we encounter another 20 year old switch and then we move that 
logic within the DSA framework?
-- 
Florian