linux-kernel - Re: [PATCH] lib/tests: Make RANDSTRUCT_KUNIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202506021107.EA2F1CBDB8@keescook>
Date: Mon, 2 Jun 2025 11:08:50 -0700
From: Kees Cook <kees@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	"Gustavo A . R . Silva" <gustavoars@...nel.org>,
	David Gow <davidgow@...gle.com>, linux-hardening@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/tests: Make RANDSTRUCT_KUNIT_TEST depend on
 RANDSTRUCT

On Mon, Jun 02, 2025 at 04:49:51PM +0200, Geert Uytterhoeven wrote:
> When CONFIG_RANDSTRUCT is not enabled, all randstruct tests are skipped.
> Move this logic from run-time to config-time, to avoid people building
> and running tests that do not do anything.

I don't like doing this because it means that looking at CI output means
I can't tell if the test was not built or if the config was not
included. I want to always have the test available, but skip the test if
the config is missing.

-Kees

-- 
Kees Cook