linux-kernel - Re: [PATCH] efi/libstub: use 'targets' instead of extra-y in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXHEkHMPMJwsMc8WAmsMhJn3ynHqJku=jeKQOT0T_aNqNA@mail.gmail.com>
Date: Mon, 2 Jun 2025 20:13:12 +0200
From: Ard Biesheuvel <ardb@...nel.org>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org
Subject: Re: [PATCH] efi/libstub: use 'targets' instead of extra-y in Makefile

On Mon, 2 Jun 2025 at 20:11, Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> These objects are built as prerequisites of %.stub.o files.
> There is no need to use extra-y, which is planned for deprecation.
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

Acked-by: Ard Biesheuvel <ardb@...nel.org>

I misunderstood what extra-y was for - note that
arch/arm64/kernel/pi/Makefile has the same issue.

> ---
>
>  drivers/firmware/efi/libstub/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile
> index d23a1b9fed75..5ce9f2098b99 100644
> --- a/drivers/firmware/efi/libstub/Makefile
> +++ b/drivers/firmware/efi/libstub/Makefile
> @@ -102,7 +102,7 @@ lib-$(CONFIG_EFI_ZBOOT)             += zboot.o $(zboot-obj-y)
>
>  lib-$(CONFIG_UNACCEPTED_MEMORY) += unaccepted_memory.o bitmap.o find.o
>
> -extra-y                                := $(lib-y)
> +targets                                := $(lib-y)
>  lib-y                          := $(patsubst %.o,%.stub.o,$(lib-y))
>
>  # Even when -mbranch-protection=none is set, Clang will generate a
> --
> 2.43.0
>