linux-kernel - Re: [PATCH ath-next v3] wifi: ath11k: validate ath11k_crypto_mode on top of ath11k_core_qmi_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a5852c1-8595-41af-9a9c-282bd508842b@oss.qualcomm.com>
Date: Mon, 2 Jun 2025 11:44:01 -0700
From: Jeff Johnson <jeff.johnson@....qualcomm.com>
To: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>, jjohnson@...nel.org
Cc: ~lkcamp/patches@...ts.sr.ht, linux-wireless@...r.kernel.org,
        ath11k@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH ath-next v3] wifi: ath11k: validate ath11k_crypto_mode on
 top of ath11k_core_qmi_firmware_ready

On 5/22/2025 1:01 PM, Rodrigo Gobbi wrote:
> if ath11k_crypto_mode is invalid (not ATH11K_CRYPT_MODE_SW/ATH11K_CRYPT_MODE_HW),
> ath11k_core_qmi_firmware_ready() will not undo some actions that was previously
> started/configured. Do the validation as soon as possible in order to avoid
> undoing actions in that case and also to fix the following smatch warning:
> 
> drivers/net/wireless/ath/ath11k/core.c:2166 ath11k_core_qmi_firmware_ready()
> warn: missing unwind goto?
> 
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>

Since this issue was previously reported, I'm adding:
Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Dan Carpenter <error27@...il.com>
Closes: https://lore.kernel.org/r/202304151955.oqAetVFd-lkp@intel.com/
Fixes: aa2092a9bab3 ("ath11k: add raw mode and software crypto support")