linux-kernel - Re: [PATCH 0/9] ALSA: usb-audio: Support jack detection on Sony DualSense PS5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c2b3de3-700c-4ee8-9650-6033a4882d58@collabora.com>
Date: Mon, 2 Jun 2025 22:35:22 +0300
From: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To: Takashi Iwai <tiwai@...e.de>
Cc: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 kernel@...labora.com, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/9] ALSA: usb-audio: Support jack detection on Sony
 DualSense PS5

On 6/2/25 5:55 PM, Takashi Iwai wrote:
> On Mon, 26 May 2025 16:07:39 +0200,
> Cristian Ciocaltea wrote:
>>
>> The Sony DualSense PS5 controller has an internal mono speaker, but it
>> also provides a 3.5mm jack socket for headphone output and headset
>> microphone input.
>>
>> Since this is a UAC1 device, it doesn't advertise any jack detection
>> capability.  However, the controller is able to report HP & MIC insert
>> events via HID, i.e. through a dedicated input device managed by the
>> hid-playstation driver [1].
>>
>> This patch series implements a quirk to create the jack controls for
>> headphone and headset mic, respectively, and registers an input handler
>> for each of them in order to intercept the related hotplug events.
>>
>> It's worth noting there is no hard dependency on the HID patch set [1],
>> as the usb-audio driver will simply bind the jack controls to the input
>> devices when they become available - this is managed internally by the
>> input handler framework.
>>
>> Unrelated to the above, the series also provides fixes to a bunch of
>> general coding style issues as reported by checkpatch.
>>
>> [1] https://lore.kernel.org/all/20250526-dualsense-hid-jack-v1-0-a65fee4a60cc@collabora.com/
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
> 
> Thanks for patches.  Through a quick glance, the code change looks OK,
> but since it's with significant amount of changes, so I'll postpone
> after 6.16 merge window (once after I'm back from traveling).

Sure, no worries, take your time!  Thanks for the early feedback!

Cristian