linux-kernel - Re: [PATCH v2 1/1] dt-bindings: mmc: mxs-mmc: change ref to mmc-controller-common.yaml from mmc-controller.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174889320959.2722772.656313710897661883.robh@kernel.org>
Date: Mon, 02 Jun 2025 14:40:09 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Sascha Hauer <s.hauer@...gutronix.de>, imx@...ts.linux.dev, 
 Conor Dooley <conor+dt@...nel.org>, linux-arm-kernel@...ts.infradead.org, 
 linux-mmc@...r.kernel.org, Fabio Estevam <festevam@...il.com>, 
 wahrenst@....net, linux-kernel@...r.kernel.org, 
 Ulf Hansson <ulf.hansson@...aro.org>, devicetree@...r.kernel.org, 
 Shawn Guo <shawnguo@...nel.org>, 
 Pengutronix Kernel Team <kernel@...gutronix.de>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: Re: [PATCH v2 1/1] dt-bindings: mmc: mxs-mmc: change ref to
 mmc-controller-common.yaml from mmc-controller.yaml


On Mon, 02 Jun 2025 11:01:47 -0400, Frank Li wrote:
> Change ref to mmc-controller-common.yaml from mmc-controller.yaml because
> imx23/imx28 use dual mode controller (spi and mmc). So default dts node
> name use spi instead of mmc. The legacy reason, it use difference
> compatible string to distringuish work mode (spi / mmc).
> 
> Fix below CHECK_DTB warnings:
> arch/arm/boot/dts/nxp/mxs/imx23-olinuxino.dtb: spi@...10000 (fsl,imx23-mmc): $nodename:0: 'spi@...10000' does not match '^mmc(@.*)?$'
> 
> Additional add clocks property.
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> change in v2
> - add clocks to required
> - fix typo legancy in commit message
> ---
>  Documentation/devicetree/bindings/mmc/mxs-mmc.yaml | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/mxs-mmc.example.dtb: mmc@...10000 (fsl,imx28-mmc): 'clocks' is a required property
	from schema $id: http://devicetree.org/schemas/mmc/mxs-mmc.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250602150147.947883-1-Frank.Li@nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.